<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123392/">https://git.reviewboard.kde.org/r/123392/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks! For sketch/gemini this change is fine, too, because it should share the resources with krita.</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On April 16th, 2015, 11:11 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Tomas Mecir and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 16, 2015, 11:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"appdata" gets resolved to "share/appname" with KStandardDirs. And <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">appname</code> will be the name of the KApplication app, whatever that is. So with plugins one better uses "data" and explicitely writes the prefix of the respective program (or plugin) whose data/resources should be accessed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See "A type that is added by the class KApplication" etc. in
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKStandardDirs.html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch changes most usages of "appdata" to "data". From a quick test Krita and Sheets still seem to work for what got changed (Krita Sketch and Krita Gemini not yet tested for what is possible).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Those usages with <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KoScript*</code> classes I did not touch (yet), as there potentially things should be resolved relative to the real app (not investigated further so far, so no clue).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/crashreporter/mainwindow.cpp <span style="color: grey">(eff5516)</span></li>
<li>krita/plugins/extensions/resourcemanager/resourcebundle.cpp <span style="color: grey">(e5aacad)</span></li>
<li>krita/ui/input/config/kis_input_configuration_page.cpp <span style="color: grey">(a1d34c9)</span></li>
<li>krita/ui/input/kis_input_profile_manager.cpp <span style="color: grey">(84222d2)</span></li>
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(4d5db5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123392/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>