<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123391/">https://git.reviewboard.kde.org/r/123391/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">has my blessing unless someone offers to fix the plugin asap</p></pre>
<br />
<p>- Camilla Boemann</p>
<br />
<p>On April 16th, 2015, 8:03 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Mani Chandrasekar.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 16, 2015, 8:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When Calligra was switched from KParts to the own KoPart system, the googledocs plugin suffered from being based on KPart::Plugin. Since it was disabled due to that from build in October 2013, noone has cared about it, and given it has been in staging for 3 years before that, without leaving that, also does not make me much hope this will change anytime soon :(</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, given no maintainer, spring cleaning time and also the platform port, I propose to remove the plugin now, noting it like the other stuff removed before in the OBSOLETE.txt. So when somebody has time and interest one day again, they know where to find something to start from :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For keeping 2.9 close to frameworks, I propose to remove the plugin already in 2.9.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would commit this April 30th, unless someone objects (and IMHO only some again working plugin would be a real objection :) )</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CalligraProducts.cmake <span style="color: grey">(d63f2f1)</span></li>
<li>OBSOLETE.TXT <span style="color: grey">(930252f)</span></li>
<li>doc/stage/menus.docbook <span style="color: grey">(2044bbe)</span></li>
<li>plugins/staging/CMakeLists.txt <span style="color: grey">(16f36d7)</span></li>
<li>plugins/staging/googledocs/CMakeLists.txt <span style="color: grey">(07a9569)</span></li>
<li>plugins/staging/googledocs/Messages.sh <span style="color: grey">(d6dd433)</span></li>
<li>plugins/staging/googledocs/authenticationdialog.ui <span style="color: grey">(b1c1853)</span></li>
<li>plugins/staging/googledocs/documentlist.ui <span style="color: grey">(7354879)</span></li>
<li>plugins/staging/googledocs/documentlistwindow.h <span style="color: grey">(149598d)</span></li>
<li>plugins/staging/googledocs/documentlistwindow.cpp <span style="color: grey">(f72fbe1)</span></li>
<li>plugins/staging/googledocs/googlecontenthandler.h <span style="color: grey">(6bcce67)</span></li>
<li>plugins/staging/googledocs/googlecontenthandler.cpp <span style="color: grey">(fe27cdf)</span></li>
<li>plugins/staging/googledocs/googledocs-sheets.rc <span style="color: grey">(209c84a)</span></li>
<li>plugins/staging/googledocs/googledocs-stage.rc <span style="color: grey">(209c84a)</span></li>
<li>plugins/staging/googledocs/googledocs-words.rc <span style="color: grey">(209c84a)</span></li>
<li>plugins/staging/googledocs/googledocument.h <span style="color: grey">(88b4aaa)</span></li>
<li>plugins/staging/googledocs/googledocument.cpp <span style="color: grey">(6b0bc42)</span></li>
<li>plugins/staging/googledocs/googledocumentlist.h <span style="color: grey">(a929914)</span></li>
<li>plugins/staging/googledocs/googledocumentlist.cpp <span style="color: grey">(40b7ece)</span></li>
<li>plugins/staging/googledocs/googledocumentservice.h <span style="color: grey">(db1f918)</span></li>
<li>plugins/staging/googledocs/googledocumentservice.cpp <span style="color: grey">(e8d377a)</span></li>
<li>plugins/staging/googledocs/images/dialog-cancel.png <span style="color: grey">(edc89a8)</span></li>
<li>plugins/staging/googledocs/images/document-import.png <span style="color: grey">(0453157)</span></li>
<li>plugins/staging/googledocs/images/document.png <span style="color: grey">(8d7b377)</span></li>
<li>plugins/staging/googledocs/images/presentation.png <span style="color: grey">(d2a21d9)</span></li>
<li>plugins/staging/googledocs/images/spreadsheet.png <span style="color: grey">(9f8c807)</span></li>
<li>plugins/staging/googledocs/loginwindow.h <span style="color: grey">(a96abbf)</span></li>
<li>plugins/staging/googledocs/loginwindow.cpp <span style="color: grey">(d1bf866)</span></li>
<li>plugins/staging/googledocs/onlinedocument.h <span style="color: grey">(bdf7666)</span></li>
<li>plugins/staging/googledocs/onlinedocument.cpp <span style="color: grey">(d6d0872)</span></li>
<li>plugins/staging/googledocs/onlineservices.qrc <span style="color: grey">(9c32924)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123391/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>