<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123286/">https://git.reviewboard.kde.org/r/123286/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The pivot tables related files can be found under sheets/dialogs/ (from where it is implemented) and we can remove the implementation which was done using staging plugin. So, the patch seems good.</p></pre>
<br />
<p>- Jigar Raisinghani</p>
<br />
<p>On April 7th, 2015, 6:06 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Tomas Mecir and Jigar Raisinghani.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 7, 2015, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems that in f7e9c2f7955a19ccf657f321f93d2f1ec6a1ea97 the Pivot tables plugin was integrated into Sheets, but without also deleting the plugin from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">plugins/staging/pivottables</code>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Attached patch does that. But as I have no real clue and might have missed something, Jigar, please tell if I got that correctly and applying this patch is correct.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CalligraProducts.cmake <span style="color: grey">(588155f)</span></li>
<li>plugins/staging/CMakeLists.txt <span style="color: grey">(0e0c88e)</span></li>
<li>plugins/staging/pivottables/CMakeLists.txt <span style="color: grey">(6972fbb)</span></li>
<li>plugins/staging/pivottables/Messages.sh <span style="color: grey">(e0bb4f2)</span></li>
<li>plugins/staging/pivottables/pivot.h <span style="color: grey">(baf5c8a)</span></li>
<li>plugins/staging/pivottables/pivot.cpp <span style="color: grey">(c9141b8)</span></li>
<li>plugins/staging/pivottables/pivot.ui <span style="color: grey">(0256690)</span></li>
<li>plugins/staging/pivottables/pivotfilters.h <span style="color: grey">(1e2bfc9)</span></li>
<li>plugins/staging/pivottables/pivotfilters.cpp <span style="color: grey">(9db7908)</span></li>
<li>plugins/staging/pivottables/pivotfilters.ui <span style="color: grey">(cb7c567)</span></li>
<li>plugins/staging/pivottables/pivotmain.h <span style="color: grey">(a2fa033)</span></li>
<li>plugins/staging/pivottables/pivotmain.cpp <span style="color: grey">(aef13cf)</span></li>
<li>plugins/staging/pivottables/pivotmain.ui <span style="color: grey">(3471394)</span></li>
<li>plugins/staging/pivottables/pivotoptions.h <span style="color: grey">(f146735)</span></li>
<li>plugins/staging/pivottables/pivotoptions.cpp <span style="color: grey">(0eeed1b)</span></li>
<li>plugins/staging/pivottables/pivotoptions.ui <span style="color: grey">(1abf2c8)</span></li>
<li>plugins/staging/pivottables/pivotplugin.h <span style="color: grey">(ec94610)</span></li>
<li>plugins/staging/pivottables/pivotplugin.cpp <span style="color: grey">(3ef23a7)</span></li>
<li>plugins/staging/pivottables/pivotsubtotals.h <span style="color: grey">(66cd361)</span></li>
<li>plugins/staging/pivottables/pivotsubtotals.cpp <span style="color: grey">(8884b38)</span></li>
<li>plugins/staging/pivottables/pivotsubtotals.ui <span style="color: grey">(c02c9dd)</span></li>
<li>plugins/staging/pivottables/pivottables.rc <span style="color: grey">(b054985)</span></li>
<li>plugins/staging/pivottables/sheetspivottables.desktop <span style="color: grey">(e65c294)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123286/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>