<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123315/">https://git.reviewboard.kde.org/r/123315/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Yue Liu.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated April 11, 2015, 9:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit e0265d14f9ea88201996b4f4ce26a465591f49c7 by Friedrich W. H. Kossebau to branch calligra/2.9.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The SVG->Karbon filter supports both SVG and compressed SVG. Instead of having one desktop file for the filter listing both mimetypes in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">X-KDE-Import</code> entry (which is a stringlist with <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">,</code> as separator), there are two separate desktop files.
Same with the Karbon->Image (PNG,JPEG) filter, instead of listing both supported mimetypes in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">X-KDE-Export</code> entry, there are two separate desktop files.
Which is fine in the current world where metadata about filters is stored in separate desktop files. There can be multiple desktop files per binary plugin.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But in the new world in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">frameworks</code> branch, metadata about filters is stored embedded (in JSON format) in the actual binary plugin. Which also means there can be only one metadata bundle per filter.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To prepare the new world, I propose to merge the desktop files already in the 2.9 branch, so it is closer to the needs of the new world, and merging branches is less in danger of conflicts.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can still export both into JPG and PNG, and still import from SVG and SVGZ in Karbon.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/image/CMakeLists.txt <span style="color: grey">(785527f)</span></li>
<li>filters/karbon/image/calligra_filter_karbon2image.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/image/calligra_filter_karbon2jpg.desktop <span style="color: grey">(a925282)</span></li>
<li>filters/karbon/image/calligra_filter_karbon2png.desktop <span style="color: grey">(628063c)</span></li>
<li>filters/karbon/svg/CMakeLists.txt <span style="color: grey">(fc5bb40)</span></li>
<li>filters/karbon/svg/calligra_filter_svg2karbon.desktop <span style="color: grey">(48a3316)</span></li>
<li>filters/karbon/svg/calligra_filter_svgz2karbon.desktop <span style="color: grey">(107298c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123315/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>