<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122946/">https://git.reviewboard.kde.org/r/122946/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Moritz Molch.</div>
<p style="color: grey;"><i>Updated April 2, 2015, 3:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 80128cb5942d8399a7e6aaf37f64d29806492689 by Moritz Molch to branch calligra/2.9.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch moves the labels into the sliders in the main UI and makes the minimal width dpi dependent to give them a reasonable size on high resolution screens. It also fixes the "two line issue" in the sliders.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The slider labels can be disabled by adding the line
sliderLabels=false
to the config at the moment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is good UI design to have elements that belong together also visually grouped together because it's easier for the eyes to parse, so it makes perfectly sense (that's also one of the reasons why gimp, blender and lots of other applications are doing this, it's not really about saving space)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on Ubuntu 14.04</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(db1728c)</span></li>
<li>krita/ui/kis_config.h <span style="color: grey">(31cc94d)</span></li>
<li>krita/ui/kis_config.cc <span style="color: grey">(27dca2d)</span></li>
<li>krita/ui/kis_paintop_box.cc <span style="color: grey">(b1135d7)</span></li>
<li>krita/ui/widgets/kis_cmb_composite.cc <span style="color: grey">(9d54f74)</span></li>
<li>krita/ui/widgets/kis_slider_spin_box.h <span style="color: grey">(4ce641a)</span></li>
<li>krita/ui/widgets/kis_slider_spin_box.cpp <span style="color: grey">(59f6b78)</span></li>
<li>krita/ui/widgets/kis_widget_chooser.h <span style="color: grey">(5f7528b)</span></li>
<li>krita/ui/widgets/kis_widget_chooser.cpp <span style="color: grey">(3a699a8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122946/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>