<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122858/">https://git.reviewboard.kde.org/r/122858/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After fixing the issues dmitry noted, I'll push the patch (in a bunch of separate commits). The changes all look good to me!</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On March 8th, 2015, 6:52 p.m. UTC, Moritz Molch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Moritz Molch.</div>
<p style="color: grey;"><i>Updated March 8, 2015, 6:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes some UI related bugs and improves the usability especially for new / casual users like myself by removing some clutter and bringing in some consistency.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I detail it modifies:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Create filter layer / Filter Mask
This fixes the treeview, slightly changes the layout and adds a scrollarea
to be usable on smaller screens, changes "Name" label to "Layer Name" to be
consistent with the "create fill layer" and "create file layer" widgets,
disables the preset buttons when the filter has no configuration</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Create fill layer
Fix resizing of the pattern widget, and removes unnecessary pattern label</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove unnecessary "Tag:" label and set it as the tooltip in TagChooserWidget.
By default the entry says "All presets", so the user already knows what it does.
This also adds to consistency with most other dropdowns in the interface</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Removed the statustip from the "Duplicate Layer or Mask" button in the layer docker.
This is the only button in krita that has it set and it's annoying to see the statusbar
flash each time you hover over that one button. Also the info is already in the tooltip.</p>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kind regards,
Moritz</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on Ubuntu 14.04</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/generators/pattern/wdgpatternoptions.ui <span style="color: grey">(f92a7ec)</span></li>
<li>krita/ui/forms/wdgdlggeneratorlayer.ui <span style="color: grey">(d80a98d)</span></li>
<li>krita/ui/forms/wdgfilternodecreation.ui <span style="color: grey">(c616feb)</span></li>
<li>krita/ui/forms/wdgfilterselector.ui <span style="color: grey">(405722b)</span></li>
<li>krita/ui/forms/wdggenerators.ui <span style="color: grey">(e9ffca8)</span></li>
<li>krita/ui/widgets/kis_filter_selector_widget.h <span style="color: grey">(360aa67)</span></li>
<li>krita/ui/widgets/kis_filter_selector_widget.cc <span style="color: grey">(a16abd8)</span></li>
<li>libs/widgets/KoTagChooserWidget.cpp <span style="color: grey">(a625a1a)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui <span style="color: grey">(d38262e)</span></li>
<li>krita/plugins/generators/pattern/kis_wdg_pattern.cpp <span style="color: grey">(c75d20c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122858/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>