<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2015-03-06 8:25 GMT+01:00 Dmitry Kazakov <span dir="ltr"><<a href="mailto:dimula73@gmail.com" target="_blank">dimula73@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div>Hi!<br><br></div>I looked through the patch and updated the google docs:<br><a href="https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit#" target="_blank">https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit#</a><br><br></div>The changes which I believe we must fix before applying it to master:<br><br>1) Inlined functions. They are not covered by the KDE style policy, so I believe we should follow Qt- and KDE- style of handling inlined functions with the opening brace at the signature line. It applies only to the functions declared *and* defined inside the class itself.<br></div></div></div></div></blockquote><div><br></div><div>I can't see Qt following this rigorously. Here's an example of both styles mixed in the same file:</div><div><br></div><div> <a href="https://github.com/qtproject/qtbase/blob/dev/src/corelib/io/qfileinfo_p.h">https://github.com/qtproject/qtbase/blob/dev/src/corelib/io/qfileinfo_p.h</a></div><div><br></div><div>Why not try to be consistent in Calligra and use the same style everywhere (inline or not inline)? Less rules to remember.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><br>2) "Wrong alignment of function parameters". See the corresponding topic in the google docs. Astyle seems to be a bit broken here, because in some places it applies correctly, and in some not. The units that are always wrong are constructors.<br><br>3) "Indentation of multiline conditionals is wrong". See the corresponding topic in the google docs. Should be 8 spaces instead of 12.<br><br></div>I think we should commit the patch only after we fix at least these three issues.<br><br></div>(optional)<br></div>4) I really feel we must *not* follow one-line-if-always-with-braces rule. 'if (some_stuff) return 0' is perfectly ok in my opinion. But this is my opinion only and I cannot block the patch with that. I only search for support from other developers in this topic.<br></div></blockquote><div><br></div><div>I have no strong opinion on this. But isn't the point that we pick a rule and stick to it? The one-line-if-always-with-braces rule has been in effect in Calligra for quite a while. It also has the benefit of 1) less rules to remember, 2) consistent with kdelibs.</div><div><br></div><div>Regards,</div><div>Elvis</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><br></div></div></div></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, Mar 5, 2015 at 11:05 AM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org" target="_blank">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On Thu, 5 Mar 2015, C. Boemann wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
As i already like the previous results this is just an improvement afaict.<br>
<br>
However, as a pure enhancement, do you know how difficult it would be to reformat all ctor initialize statements to be like:<br>
<br>
class::class()<br>
: super()<br>
, member(val)<br>
{<br>
<br>
I know it would require a patch, just wondering how much work it would be. If you don't want to spend time on it we can keep it as it is - but we have like 3 different styles in use so it would be nice to clear it up too,<br>
<br>
</blockquote>
<br></span>
I would love that as well. This style of initializer lists is the easiest to maintain.<span><font color="#888888"><br>
<br>
Boudewijn</font></span><div><div><br>
______________________________<u></u>_________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org" target="_blank">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" target="_blank">https://mail.kde.org/mailman/<u></u>listinfo/calligra-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><span class=""><font color="#888888">-- <br><div>Dmitry Kazakov</div>
</font></span></div>
<br>_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br>
<br></blockquote></div><br></div></div>