<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau <span dir="ltr"><<a href="mailto:kossebau@kde.org" target="_blank">kossebau@kde.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
so I spent quite some time scanning the sources, below is what I found as<br>
TODO.<br>
<br>
So the idea still is: put 3rd-party code into a subdir "3rdparty" and put<br>
generated and committed code into a subdir "generated", either locally or<br>
globally. This allows automatted handling of such code files in scripts/greps<br>
etc, and also helps understanding code when looking for the big picture.<br>
<br>
I propose to apply the changes listed below in 2.9, I do not see a risk in<br>
breaking something. Only the cmake files should be affected, and perhaps some<br>
includes. The more things are consistent in 2.9 with master/future frameworks<br>
branch, the better.<br>
<br>
Please also tell what generated files or 3rd-party code is missing from the<br>
list below<br></blockquote><div><br></div><div>I did just a quick search, but it seems you've been thorough.</div><div><br></div><div>I wonder about the two files:</div><div><br></div><div>  krita/plugins/formats/jpeg/iccjpeg.(h|c)</div><div><br></div><div>They are 3rdparty code afaics, but not in their own directory. I guess the 3rdparty README in that directory pertains to them?</div><div><br></div><div>Maybe they should be given their own directory?</div><div><br></div><div>Nice work,</div><div>Elvis</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Will do that 6th evening or 7th morning, unless someone objects.<br>
<br>
3rdparty code<br>
=============<br>
<br>
TODO:<br>
filters/sheets/qpro/libqpro<br>
-> filters/sheets/qpro/3rdparty/libqpro<br>
<br>
filters/words/msword-odf/wv2<br>
from what I heard this can be considered a fork already.<br>
but for now I would still treat it as 3rdparty lib,<br>
until the further fate of this lib has been discussed<br>
-> filters/words/msword-odf/3rdparty/wv2<br>
<br>
filters/words/rtf/import/rtf-qt<br>
-> filters/words/rtf/import/3rdparty/rtf-qt<br>
<br>
gemini/cloud/dropbox/libs/<br>
@leinir, where is that code from?<br>
-> gemini/cloud/dropbox/3rdparty/*<br>
<br>
kexi/migration/mdb/src/mdbtools/<br>
-> kexi/migration/mdb/3rdparty/mdbtools/<br>
<br>
krita/plugins/extensions/gmic/src<br>
-> krita/plugins/extensions/gmic/3rdparty/gmic<br>
<br>
krita/plugins/formats/xcf/<br>
most besides kis_xcf_import.*, CMakeLists.txt,*.desktop<br>
-> krita/plugins/formats/xcf/3rdparty/xcftools<br>
<br>
plan/plugins/schedulers/rcps/libs<br>
-> plan/plugins/schedulers/rcps/3rdparty/LibRCPS<br>
<br>
plugins/formulashape/itexToMML<br>
-> plugins/formulashape/3rdparty/itexToMML<br>
<br>
sheets/mdds<br>
-> sheets/3rdparty/mdds<br>
<br>
<br>
Already proper:<br>
3rdparty/*<br>
<br>
<br>
Generated code<br>
==============<br>
<br>
TODO: (?)<br>
libs/db/parser/sqlscanner.cpp<br>
libs/db/keywords.cpp<br>
libs/db/drivers/*/*keywords.cpp<br>
kexi/kexidb/drivers/*/*keywords.cpp<br>
libs/db will be replaced by predicate in 3.0, so let's just ignore those<br>
@jstaniek/piggz, the same is true for kexi/kexidb/, right? So could be ignored<br>
as well.<br>
<br>
Already proper:<br>
filters/libmso/generated/simpleParser.*<br>
filters/libmsooxml/generated/generatedShapes.h<br>
(though generator.cpp is in the same dir, without instructions. ideally would<br>
be a separate dir)<br>
<div class=""><div class="h5"><br>
Cheers<br>
Friedrich<br>
_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br>
</div></div></blockquote></div><br></div></div>