<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122035/">https://git.reviewboard.kde.org/r/122035/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Lassi Nieminen and Jarosław Staniek.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 12:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is a little something that I hacked on in my sickbed. It's all very simple stuff, but I managed to accumulate quite a lot over the weeks.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Short summary:
- Some refactoring: a generic odf reader class
- New: support for ODS (spreadsheets)
- Support for many draw objects
- Support for frames
- Support for charts
- Much simplified code in the reader backend due to smart macros</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There should be <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">no</em> API changes for external users of this library. This is tested using existing filters, mainly the docx export filter.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It would be nice to get this into master before we start on the qt5 port. The changes are limited to a very small part of the source tree and even though they are somewhat biggish, they are very simple in nature.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with extensive traces and existing filters that use the library.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libodf2/CMakeLists.txt <span style="color: grey">(3792771)</span></li>
<li>filters/libodf2/KoXmlStreamReader.h <span style="color: grey">(a06c8ec)</span></li>
<li>filters/libodf2/KoXmlUtils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoXmlUtils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/CMakeLists.txt <span style="color: grey">(e4bfdda)</span></li>
<li>filters/libodfreader/OdfChartReader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfChartReader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfChartReaderBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfChartReaderBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfDrawReader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfDrawReader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfDrawReaderBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfDrawReaderBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfReader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfReader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfReaderBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfReaderBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfReaderInternals.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdfTextReader.h <span style="color: grey">(d6c5bc8)</span></li>
<li>filters/libodfreader/OdfTextReader.cpp <span style="color: grey">(ab6514d)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.h <span style="color: grey">(49c25ea)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.cpp <span style="color: grey">(30219ff)</span></li>
<li>filters/libodfreader/OdsReader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdsReader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdsReaderBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdsReaderBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodfreader/OdtReader.h <span style="color: grey">(22ae935)</span></li>
<li>filters/libodfreader/OdtReader.cpp <span style="color: grey">(48e1037)</span></li>
<li>filters/libodfreader/OdtReaderBackend.h <span style="color: grey">(ae321ab)</span></li>
<li>filters/libodfreader/OdtReaderBackend.cpp <span style="color: grey">(cdc59f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122035/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>