<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122535/">https://git.reviewboard.kde.org/r/122535/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 23rd, 2015, 1:38 p.m. CET, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good!
After rewriting history (src/ dir now exist, tests/ are now in examples/, etc.) I integrated your patch into the scratch repo (master) ssh://git@git.kde.org/scratch/staniek/kproperty.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Copy of the line style code makes sense, it's universal. KoUnit - does not, it's office suite-specific. So I disabled KoUnit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also removed koproperty_export.h; kproperty_export.h should be generated by cmake.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please fix the order of args in QObject::tr(const char * sourceText, const char * disambiguation) as we noticed.
Please fix the build as I obviously broken it while rewriting the history ;)</p></pre>
</blockquote>
<p>On February 23rd, 2015, 3:04 p.m. CET, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: The main CMakeLists.txt is missing among other things.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This rr can be marked as submitted (Close->Submitted).</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On February 11th, 2015, 11:10 p.m. CET, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Friedrich W. H. Kossebau, Jarosław Staniek, and Wojciech Kapuscinski.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2015, 11:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port of koproerty to qt5 for comment. Currently buggy and incomplete, up for review for comments!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Copied some files from calligra to allow building.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran tests/propertytet to see what happens
Gui loads and shows properties, some work and some dont!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/pixmapedit.cpp <span style="color: grey">(a11ae93)</span></li>
<li>editors/pointedit.h <span style="color: grey">(02abeac)</span></li>
<li>editors/pointedit.cpp <span style="color: grey">(e471263)</span></li>
<li>editors/pointfedit.h <span style="color: grey">(e2992fa)</span></li>
<li>editors/pointfedit.cpp <span style="color: grey">(e4e75e6)</span></li>
<li>editors/rectedit.h <span style="color: grey">(a635871)</span></li>
<li>editors/rectedit.cpp <span style="color: grey">(105cd9e)</span></li>
<li>editors/sizeedit.h <span style="color: grey">(9886650)</span></li>
<li>editors/sizeedit.cpp <span style="color: grey">(08af042)</span></li>
<li>editors/sizefedit.h <span style="color: grey">(ca0806d)</span></li>
<li>editors/sizefedit.cpp <span style="color: grey">(825ae56)</span></li>
<li>editors/sizepolicyedit.h <span style="color: grey">(7b563ca)</span></li>
<li>editors/sizepolicyedit.cpp <span style="color: grey">(fa23e58)</span></li>
<li>editors/spinbox.h <span style="color: grey">(55afb92)</span></li>
<li>editors/spinbox.cpp <span style="color: grey">(1763861)</span></li>
<li>editors/stringedit.h <span style="color: grey">(5159f8b)</span></li>
<li>editors/stringedit.cpp <span style="color: grey">(49f3cdf)</span></li>
<li>editors/stringlistedit.h <span style="color: grey">(faafae8)</span></li>
<li>editors/symbolcombo.h <span style="color: grey">(8a9360a)</span></li>
<li>editors/symbolcombo.cpp <span style="color: grey">(1c67ddc)</span></li>
<li>editors/timeedit.h <span style="color: grey">(0b853a3)</span></li>
<li>editors/timeedit.cpp <span style="color: grey">(aa3665e)</span></li>
<li>editors/urledit.h <span style="color: grey">(82d072d)</span></li>
<li>editors/utils.h <span style="color: grey">(883c452)</span></li>
<li>editors/utils.cpp <span style="color: grey">(7ec6938)</span></li>
<li>koproperty_export.h <span style="color: grey">(e4664b7)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1c02bfe)</span></li>
<li>tests/main.cpp <span style="color: grey">(45a7c55)</span></li>
<li>tests/test.cpp <span style="color: grey">(2be3bb5)</span></li>
<li>editors/cursoredit.cpp <span style="color: grey">(4bd0c6b)</span></li>
<li>editors/dateedit.h <span style="color: grey">(5adc02e)</span></li>
<li>editors/dateedit.cpp <span style="color: grey">(d3d87f2)</span></li>
<li>editors/datetimeedit.h <span style="color: grey">(d50d81e)</span></li>
<li>editors/datetimeedit.cpp <span style="color: grey">(e5f7b13)</span></li>
<li>editors/dummywidget.h <span style="color: grey">(35b8ade)</span></li>
<li>editors/fontedit.h <span style="color: grey">(642ca02)</span></li>
<li>editors/fontedit.cpp <span style="color: grey">(cf441d2)</span></li>
<li>editors/linestyleedit.h <span style="color: grey">(43ca61c)</span></li>
<li>editors/linestyleedit.cpp <span style="color: grey">(64c0e92)</span></li>
<li>editors/pixmapedit.h <span style="color: grey">(0d71800)</span></li>
<li>CMakeLists.txt <span style="color: grey">(87f206d)</span></li>
<li>DefaultFactory.cpp <span style="color: grey">(61f7e2a)</span></li>
<li>EditorDataModel.cpp <span style="color: grey">(8272888)</span></li>
<li>EditorView.h <span style="color: grey">(6bce43b)</span></li>
<li>EditorView.cpp <span style="color: grey">(94c8087)</span></li>
<li>Factory.h <span style="color: grey">(babb1b9)</span></li>
<li>Factory.cpp <span style="color: grey">(53b4210)</span></li>
<li>KoLineStyleItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoLineStyleItemDelegate_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoLineStyleModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoLineStyleModel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoLineStyleSelector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoLineStyleSelector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoUnit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KoUnit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>Property.h <span style="color: grey">(e4b3bd0)</span></li>
<li>Property.cpp <span style="color: grey">(37d2b7d)</span></li>
<li>Set.h <span style="color: grey">(b3c4c2a)</span></li>
<li>Set.cpp <span style="color: grey">(4a0f787)</span></li>
<li>Utils.cpp <span style="color: grey">(0ee8c99)</span></li>
<li>editors/booledit.h <span style="color: grey">(8f1cb6d)</span></li>
<li>editors/booledit.cpp <span style="color: grey">(207140f)</span></li>
<li>editors/coloredit.h <span style="color: grey">(1c35ec9)</span></li>
<li>editors/coloredit.cpp <span style="color: grey">(1d03a9f)</span></li>
<li>editors/combobox.h <span style="color: grey">(225c70b)</span></li>
<li>editors/combobox.cpp <span style="color: grey">(4270326)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122535/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>