<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122546/">https://git.reviewboard.kde.org/r/122546/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Февраль 24th, 2015, 7:40 п.п. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122546/diff/1/?file=348538#file348538line126" style="color: black; font-weight: bold; text-decoration: underline;">libs/kotext/KoTextInlineRdf.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">enum Type {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KoSection</span> <span class="o">*</span><span class="n">section</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this a normal pointer when all the other similar pointers are QWeakPOinter? Is there something fundamentally differenti with the KoSection pointer?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KoSection isn't QObject derived, so can't use QWeakPointer. I can make KoSection QObject derived, but it seems unreasonable in that case.</p></pre>
<br />
<p>- Denis</p>
<br />
<p>On Февраль 12th, 2015, 8:22 п.п. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann and Inge Wallin.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Фев. 12, 2015, 8:22 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">List of changes:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">//Global
1) New KoRDFBasicSemanticItem was extracted from KoRDFSemanticItem. Basic version doesn't have notifications, custom representation in text and so on.
2) Changed allwhere rdf urls to appropriate ones according to new newest openDocument standard
3) KoSection now handles inline rdf link
4) Many formatting fixes and minor fixes in many places:
a) Structre to "delete-on-quit" in KoTextDrag replaced with QScoperPointer
b) Minor bag in KoSectionManager sectionAtPostion() function
c) Some old FIXMEs fixed</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry for not placing some of above fixing stuff to another branch :(</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">//Author
5) Extracted CAuDocument to embed all author-related functionality like covers
6) Author has now own base class for semantics items, and CAuMetaDataManager stores all of them properly in separate file in package (author.rdf), properly handling links from main document according to RDF storing standards.
7) There is now only two semantic items for Section and Actor (in meaning of Author metadata).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now outliner is hidden (theres is comment where this docker is registred) (it isn't finished by now).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are a lot of changes allwhere, so the list above is too short. There were a big mess with rdf before (especially with prefix naming). I want to apply this changes in merge window to port them to Qt5.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I were testing while outliner docker was enabled, saving metadata for sections is working (opening, closing). You can check RDF with File-Document Information-Rdf.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/author/metadata/CAuSectionRdf.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSectionRdfEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSectionSemanticItemFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSectionSemanticItemFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSemanticItemBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSemanticItemBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugWidget.h <span style="color: grey">(ed483f0)</span></li>
<li>words/part/dockers/KWDebugWidget.cpp <span style="color: grey">(6b3bc7b)</span></li>
<li>words/part/dockers/KWNavigationWidget.cpp <span style="color: grey">(71268a4)</span></li>
<li>words/part/dockers/KWRdfDocker.h <span style="color: grey">(9ad179a)</span></li>
<li>words/part/dockers/KWRdfDocker.cpp <span style="color: grey">(5129fbe)</span></li>
<li>words/part/author/CAuDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/CAuFactory.cpp <span style="color: grey">(07c482a)</span></li>
<li>words/part/author/CAuView.cpp <span style="color: grey">(d29ddc7)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(7846861)</span></li>
<li>words/part/author/dockers/CAuOutlinerDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/dockers/CAuOutlinerDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/dockers/CAuOutlinerDockerFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/dockers/CAuOutlinerDockerFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/dockers/CAuOutlinerWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/dockers/CAuOutlinerWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuActorRdf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuActorRdf.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuActorRdfEditWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuActorSemanticItemFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuActorSemanticItemFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuMetaDataManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuMetaDataManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/author/metadata/CAuSectionRdf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/tests/TestRdf.cpp <span style="color: grey">(4017415)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(d7fea2c)</span></li>
<li>words/part/KWView.h <span style="color: grey">(e49f287)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(9cb6b82)</span></li>
<li>words/part/author/CAuDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/semanticitems/event/KoRdfCalendarEvent.cpp <span style="color: grey">(cf8e6fe)</span></li>
<li>plugins/semanticitems/event/KoEventSemanticItemFactory.cpp <span style="color: grey">(c1f191f)</span></li>
<li>plugins/semanticitems/event/KoEventSemanticItemFactory.h <span style="color: grey">(ed529c0)</span></li>
<li>libs/rdf/tests/rdf_test.cpp <span style="color: grey">(55ee566)</span></li>
<li>plugins/semanticitems/authorsection/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/semanticitems/contact/KoContactSemanticItemFactory.h <span style="color: grey">(3108047)</span></li>
<li>plugins/semanticitems/contact/KoContactSemanticItemFactory.cpp <span style="color: grey">(a7cba13)</span></li>
<li>plugins/semanticitems/contact/KoRdfFoaF.cpp <span style="color: grey">(01314a1)</span></li>
<li>libs/rdf/KoRdfSemanticItemFactoryBase.cpp <span style="color: grey">(52e35cd)</span></li>
<li>libs/rdf/KoRdfSemanticItemRegistry.h <span style="color: grey">(e64ca49)</span></li>
<li>libs/rdf/KoRdfSemanticItemRegistry.cpp <span style="color: grey">(362cc24)</span></li>
<li>libs/rdf/KoRdfSemanticItem_p.h <span style="color: grey">(0fb535e)</span></li>
<li>libs/rdf/KoRdfSemanticTree.cpp <span style="color: grey">(7d67cc9)</span></li>
<li>libs/rdf/KoSopranoTableModel.cpp <span style="color: grey">(32f1002)</span></li>
<li>libs/rdf/RdfForward.h <span style="color: grey">(b27dd8d)</span></li>
<li>libs/rdf/tests/TestSemanticItem.h <span style="color: grey">(5f015fd)</span></li>
<li>filters/libodfreader/OdtReader.cpp <span style="color: grey">(48e1037)</span></li>
<li>libs/kotext/KoSection.h <span style="color: grey">(82f4c75)</span></li>
<li>libs/kotext/KoSection.cpp <span style="color: grey">(eb83b49)</span></li>
<li>libs/kotext/KoSectionManager.cpp <span style="color: grey">(4143ca8)</span></li>
<li>libs/kotext/KoTextDrag.cpp <span style="color: grey">(03f9020)</span></li>
<li>libs/kotext/KoTextInlineRdf.h <span style="color: grey">(f367ae0)</span></li>
<li>libs/kotext/KoTextInlineRdf.cpp <span style="color: grey">(3ecccf6)</span></li>
<li>libs/kotext/KoTextRdfCore.cpp <span style="color: grey">(d5d152c)</span></li>
<li>libs/rdf/CMakeLists.txt <span style="color: grey">(d62d464)</span></li>
<li>libs/rdf/InsertSemanticObjectReferenceAction.cpp <span style="color: grey">(d812659)</span></li>
<li>libs/rdf/KoDocumentRdf.h <span style="color: grey">(caa6485)</span></li>
<li>libs/rdf/KoDocumentRdf.cpp <span style="color: grey">(a7a093a)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.h <span style="color: grey">(53d0f86)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.cpp <span style="color: grey">(c094af1)</span></li>
<li>libs/rdf/KoDocumentRdfEditWidget.ui <span style="color: grey">(4dcdedb)</span></li>
<li>libs/rdf/KoRdfBasicSemanticItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfBasicSemanticItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/rdf/KoRdfPrefixMapping.cpp <span style="color: grey">(0d592d6)</span></li>
<li>libs/rdf/KoRdfSemanticItem.h <span style="color: grey">(7e8f955)</span></li>
<li>libs/rdf/KoRdfSemanticItem.cpp <span style="color: grey">(6d19e60)</span></li>
<li>libs/rdf/KoRdfSemanticItemFactoryBase.h <span style="color: grey">(002996d)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(91dd6cb)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(bce2d47)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(b6e5d9f)</span></li>
<li>plugins/semanticitems/location/KoRdfLocation.cpp <span style="color: grey">(5f88ab7)</span></li>
<li>plugins/semanticitems/location/KoRdfLocation.h <span style="color: grey">(52cbba8)</span></li>
<li>plugins/semanticitems/location/KoLocationSemanticItemFactory.cpp <span style="color: grey">(43d8368)</span></li>
<li>plugins/semanticitems/location/KoLocationSemanticItemFactory.h <span style="color: grey">(8ce9d5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122546/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>