<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122681/">https://git.reviewboard.kde.org/r/122681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Wolthera van Hövell.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sRGB built-in and scRGB are a bit unpredictable as far as colour profiles go(scRGB in particular is a strange profile).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Elle Stone's icc profiles are a lot more stress-tested, hence I suggest we change to these as defaults for our rgb colour spaces. So I picked the sRGB and sRGB linear profiles to replace sRGB built-in and scRGB.
v2 was chosen over v4, because v2 enjoys a little more compatibility, and the v4 advantages are largely meant for cameras.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now there's one deeply controversial change I made that doubtlessly will keep people up at night:
I set the profile for 16bit integer to be linear, as 16bit is enough to enjoy all the advantages of a linear profile.(Amongst which just better colour maths)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also set our cmyk profiles to default to Chemical Proof, as that's the only one we ship.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It compiles and works, boud requested I put this aside for when we're not pushing our noses against a release.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/colorengines/lcms2/colorspaces/cmyk_f32/CmykF32ColorSpace.h <span style="color: grey">(e5cc2b8)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/cmyk_u16/CmykU16ColorSpace.h <span style="color: grey">(059e3e0)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/cmyk_u8/CmykU8ColorSpace.h <span style="color: grey">(c828d27)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/rgb_f16/RgbF16ColorSpace.h <span style="color: grey">(82bfe7f)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/rgb_f32/RgbF32ColorSpace.h <span style="color: grey">(5ea1a47)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/rgb_u16/RgbU16ColorSpace.h <span style="color: grey">(0c85fb0)</span></li>
<li>plugins/colorengines/lcms2/colorspaces/rgb_u8/RgbU8ColorSpace.h <span style="color: grey">(b37cb6d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>