<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122656/">https://git.reviewboard.kde.org/r/122656/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122656/diff/1/?file=350477#file350477line402" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiDataAwareObjectInterface::setSpreadSheetMode()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">401</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KexiDataAwareObjectInterface</span><span class="o">::</span><span class="n">setSpreadSheetMode</span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">402</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KexiDataAwareObjectInterface</span><span class="o">::</span><span class="n">setSpreadSheetMode</span><span class="p">(</span><span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">set</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use an enum maybe?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122656/diff/1/?file=350479#file350479line1673" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/tableview/KexiTableScrollArea.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect KexiTableScrollArea::cellGeometry(int row, int col) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1673</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// if (objectName() == "KexiComboBoxPopup_tv") {</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why this here?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122656/diff/1/?file=350479#file350479line1687" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/tableview/KexiTableScrollArea.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect KexiTableScrollArea::cellGeometry(int row, int col) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1687</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// if (objectName() == "KexiComboBoxPopup_tv") {</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why this here?</p></pre>
</div>
</div>
<br />
<p>- Adam Pigg</p>
<br />
<p>On February 20th, 2015, 11:47 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2015, 11:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Improve Kexi table view in combo box popups and spreadsheet mode</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This mostly fixes table designer. Query designer needs some more work.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Table designer tested, including adding/removing rows and showing combo boxes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(4c61c39352b947b6e655653804665de1d827f701)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(0c9ff503bc859fe6290431692a3e277d618b61a4)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.h <span style="color: grey">(ce1fb4a35d434565987de14f9a98eaf70a24c6ae)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.cpp <span style="color: grey">(1814a82a6f9fb79513c71a9d86a3dbe0ff11e825)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(c57918602418761279590878b664c665b5af3ec0)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(bd28547190303f4e6fdd73638e1bdb3baa880a50)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(c09b7ec76657abc3f8be0edbfd0717c89cbcf2e2)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(b73ae64a6f2eef7e96989b749e6535e9e5efdcc6)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(05c5b5549b889f827a604baddf29d4753d7addd3)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(28b5fb61804b38680120d771ce5819c5a7a274c5)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(c482a149a61f19e2d37e7e48a489fbe0c8096dea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122656/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>