<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122519/">https://git.reviewboard.kde.org/r/122519/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Roman Shtemberko</p>
<br />
<p>On Февраль 16th, 2015, 10:35 д.п. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Фев. 16, 2015, 10:35 д.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kexi table view: update vertical header sections and fix cursor movement issues
Details:
* On row inserting and deleting, update the vertical header's model (instead of manually adding header sections)
Major defect #3 at https://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View
"Update vertical header sections when # of records change"
* "select last row" works on when there are zero records
* on new row edit accepting do not jump to first row (fix regression)
* usability++: when editing is started, scroll a bit up to show next row if present
* usability++: when editing is started, ensure the very bottom of empty scroll area is displayed to help the user see what's there
* set internal margin of half of the horizontal scroll bar's height only when not in spreadsheet mode
* simplify "move to Nth row" and "move to last row" code
* internal logic change for vertical header: when new row editing starts, the new row data is added to the list of records, on Cancel it's removed so no need to check the newRowEditing flag</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested for small and large tables in data mode, tables in design mode (spreadsheet tv mode), query data and design views</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(eed4676d2bdd72a0d50f76725fff5317d1209707)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(4b412ac0d8c74036553300408f76cea946c216e8)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(e260ac40041f0c2711071e6f96b69671bbbdf242)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(c0090041ccf3b6369145f584590f1821d657363e)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(0f83338e076859294e2412a627083fbd561f70a6)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.h <span style="color: grey">(da6a89165b9f896d4b0cd2759827f51c47b61ac4)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp <span style="color: grey">(99a524fa233297b8ca5a3001dae3f8f86192d548)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.h <span style="color: grey">(753f08eb22e03b141a0ec43bfe463e89f4530353)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.cpp <span style="color: grey">(582146bb1a78e5e4b3bcb98cc01a6919508aef65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122519/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>