<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121800/">https://git.reviewboard.kde.org/r/121800/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Yue Liu, René J.V. Bertin, and Jarosław Staniek.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2015, 4:25 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anything from the possible products in the Calligra repo that does not work or build at all on a certain platform should be disabled centrally, in the central CMakeLists.txt in the section "Detect which products/features can be compiled".
The product set system is orthogonal to that: it should enable people to only build stuff they are interested in. E.g. people only wanting to build Krita. Or Kexi. Or Krita and Kexi and Words. And all that independently of the platform they are on. If they choose something that does not build on their platform, they should get a proper warning about that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course people on OSX might be also interested in "all stuff that makes sense on OS X". Which is what the product set OSX is for. Just, currently it is also used to just list stuff that currently builds. While it should better list all stuff that makes sense, independently if it is broken or unmaintained. So people see that Sheets would make sense, but is not built because it needs a maintainer for OSX.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So with this patch I propose to change things accordingly, disabling unmaintained/not building things centrally and then listing all stuff in the "OSX" product set that in theory at least would make sense on that platform.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Developers who would start to work on maintaining something that is currently disabled on their platform would then simply comment the according line with the disabling entry, so not something very complicated to do.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now my questions are:
what all would make sense on OSX, so should be listed in the product set?
and what does not build at all or does not make sense at all, so should be disabled globally?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8a3404ff)</span></li>
<li>cmake/productsets/osx.cmake <span style="color: grey">(1fe8f1c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121800/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>