<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122197/">https://git.reviewboard.kde.org/r/122197/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two more small fixes would be nice:
- When I click Next on "Alter the Detected Table Design" and then Back, Caption and Name fields are reset. This shouldn't happen.
- On the last Success page please disable ability to click Back, otherwise user may try to import twice what can't be performed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And two improvements:
- On the last Success page add message i18n("Table <resource>%1</resource> has been imported.")
- On the last Success page add an i18n("Open imported project") checkbox, OFF by default; then open the imported table if checked. For similar code with layout refer to ImportWizard::setupFinish(). How to open afterwards? We need to pass the table name back from the plugin. </p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">See KexiMainWindow::showProjectMigrationWizard() as example</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">In KexiMainWindow::slotToolsImportTables() you create QMap<QString, QString> args; and pass as an arg to KexiInternalPart::createModalDialogInstance()</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Look at ImportWizard::import() how d->args->insert("destinationDatabaseName") is used after successfull import. We need similarly, just the variable name could be "destinationTableName", right?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Back in KexiMainWindow::slotToolsImportTables() after the successful import you receive the table name using args["destinationTableName"] and use KexiMainWindow::openObject(const QString& partClass, const QString& name, Kexi::ViewMode viewMode, bool).</li>
</ol></pre>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On February 3rd, 2015, 1:26 p.m. CET, Roman Shtemberko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Roman Shtemberko.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 1:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336815">336815</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix 336815 (path issue)
Also have fixed with this patch:
Check for an empty name.
Names are no more converted to the lower case (there is some conflicts with this behavior, imported tables can not be opened after this (only after restarting an app (!?)))
Check if name is not starting with a digit (conflicts with '_' at the begining as well).
Default name is added based on sheet selected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/AlterSchemaWidget.cpp <span style="color: grey">(ea7fedd)</span></li>
<li>kexi/migration/importtablewizard.h <span style="color: grey">(a0b4dca)</span></li>
<li>kexi/migration/importtablewizard.cpp <span style="color: grey">(f3d02b9)</span></li>
<li>kexi/widget/KexiConnectionSelectorWidget.cpp <span style="color: grey">(48d3f7e)</span></li>
<li>kexi/migration/AlterSchemaWidget.h <span style="color: grey">(b29e7f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122197/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>