<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122354/">https://git.reviewboard.kde.org/r/122354/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good work :-). I think it's time for you to follow https://techbase.kde.org/Contribute/Get_a_Contributor_Account and get commit/push access. You can use me or Dmitry as your reference, and then push your patch yourself :-)</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On February 1st, 2015, 2:57 a.m. UTC, Aleksander Demko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Aleksander Demko.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2015, 2:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330185">330185</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Fixed bug Bug <span style="color: #666666">330185</span> <span style="color: #666666">-</span> Text Brush<span style="color: #666666">:</span> Letters are upside down when
Rotation is set to Drawing Angle
This bug was fixed by adding a new feature<span style="color: #666666">/</span>parameter <span style="color: #BA2121">"angleOffset"</span>
to the drawing angle option. Settings this new parameter to
<span style="color: #666666">180</span> degrees will give the expected output in this user<span style="border: 1px solid #FF0000">'</span>s <span style="color: #008000; font-weight: bold">case</span>.
The core issue is that when the drawing angle option is enabled,
an angle of <span style="color: #666666">180</span> it sent when moving the cursor RIGHT.
KisTextBrush could some how test <span style="color: #008000; font-weight: bold">for</span> this <span style="color: #008000; font-weight: bold">case</span> and manually
subtract <span style="color: #666666">180</span> to get <span style="color: #BA2121">"no rotation"</span> when travelling right, but this
would be an ugly hack.
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.h <span style="color: grey">(34469d6)</span></li>
<li>krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.cpp <span style="color: grey">(8351c3d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122354/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>