<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122240/">https://git.reviewboard.kde.org/r/122240/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Improve Kexi data-aware cell editing API</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plus #1: table view's methods for [editor creation/column width change] now use specified column/row number instead of current ones.
Plus #2: in addNewRecordRequested() we're avoiding closing editor before cursor position gets changed (programatically) and avoiding ensuring cell visibility prior to creating the editor. This can enable implementing animations in the future.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">functionality of table views remain unchanged</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(beb63430de4b8de8199a4351cf50a5804d2e2525)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(652a38ab5e92f2e58db1a8a2db215d40ebba327e)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(f7497bb3fff133fa60905c1ebbe50baf9a213593)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(917000f078e761a13f267f646bbf91eec73b8f9b)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(42e11f650b437a8f326bd816dfb787d03fad7569)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(485aa22a09cafe5dd2a68a5ad0e2df766cbd64d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122240/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>