<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122045/">https://git.reviewboard.kde.org/r/122045/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm... nothing wrong seen. But one thing seems questionable to me:
Non-odf specific stuff IMHO should stay in the filter. Otherwise every format for which import/export is added will blow up libodf2. And adds bloat to any filter that uses libodf2.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341650#file341650line125" style="color: black; font-weight: bold; text-decoration: underline;">filters/libmso/MsoUtils.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">push_back</span><span class="p">(</span> <span class="n">QPalette</span><span class="p">().</span><span class="n">color</span><span class="p">(</span> <span class="n">QPalette</span><span class="o">::</span><span class="n">Active</span><span class="p">,</span> <span class="n">QPalette</span><span class="o">::</span><span class="n">WindowText</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know, it's just moved code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please, add a TODO here that this should be something returned on the fly, as the palette colors might change during the runtime.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341663#file341663line4" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span> <span class="o">${</span><span class="nv">CMAKE_SOURCE_DIR</span><span class="o">}</span><span class="s">/filters/libmso</span> <span class="c"># for NumberFormatParser</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Including libmso files for libodf2 seems wrong as well, similar as Charting.h is non-odf stuff.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341664#file341664line31" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/chart/Charting.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">namespace</span> <span class="n">KoChart</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, this is MSO(OXML) specific stuff, no?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why would you make this part of KoChart/libodf2?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would this scale to make all data structures of other formats part of KoChart/libodf2?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341668#file341668line39" style="color: black; font-weight: bold; text-decoration: underline;">filters/sheets/excel/export/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">CMAKE_CURRENT_SOURCE_DIR</span><span class="o">}</span><span class="s">/../../xlsx/NumberFormatParser.cpp</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="c"><span class="hl">#</span>${CMAKE_CURRENT_SOURCE_DIR}/../../xlsx/NumberFormatParser.cpp</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lines can be removed.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341669#file341669line39" style="color: black; font-weight: bold; text-decoration: underline;">filters/sheets/excel/import/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">CMAKE_CURRENT_SOURCE_DIR</span><span class="o">}</span><span class="s">/../../xlsx/NumberFormatParser.cpp</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="c"><span class="hl">#</span>${CMAKE_CURRENT_SOURCE_DIR}/../../xlsx/NumberFormatParser.cpp</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Line can be removed.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122045/diff/1/?file=341699#file341699line28" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/docx/import/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">CMAKE_SOURCE_DIR</span><span class="o">}</span><span class="s">/filters/sheets/xlsx/NumberFormatParser.cpp</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c"><span class="hl">#</span>${CMAKE_SOURCE_DIR}/filters/sheets/xlsx/NumberFormatParser.cpp</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Line can be removed.</p></pre>
</div>
</div>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On Januar 13th, 2015, 9:18 nachm. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Lassi Nieminen and Jarosław Staniek.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2015, 9:18 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is a refactoring of how charts are handled in the filters. There are two purposes of it:
1. Make it sane in general. As it was before, the various filters where reaching into each other for bits and pieces of code, and the naming was strange in places. There was also a strange mixture of MS binary and MSOOXML concepts in the same files.
2. To prepare for the next step which is sharing storage classes for charts between the filters and the chart shape. As it is now, many defines and both loading and saving is duplicated all over Calligra. This is not the way we want things to be.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is hardly any new code in here, only rearranging of what was already there. Here is a summary (everything happens inside the filters/ tree):
- Factor out common parts and move them to libodf2/charts
- Factor out the parts common to MS handling and move them to libmso/
- Move common parts within the ooxml filters from the xlsx tree to libmsooxml/
- Move things that only have to do with MS binary parts to libmso/
- Rename the vaguely named namespace "Charting" to "KoChart"
- Rename ChartExport to KoOdfChartWriter, which should be clearer
- Make the filters use and link to the libraries instead of each other</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is no new code at all, only rearrangement. But all the filters work as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libmso/CMakeLists.txt <span style="color: grey">(19aced3)</span></li>
<li>filters/libmso/MsoUtils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmso/MsoUtils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmso/NumberFormatParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmso/NumberFormatParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmso/XlsUtils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmsooxml/CMakeLists.txt <span style="color: grey">(7dc2d7f)</span></li>
<li>filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h <span style="color: grey">(e8748ef)</span></li>
<li>filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp <span style="color: grey">(c7bd7fe)</span></li>
<li>filters/libmsooxml/MsooXmlImport.cpp <span style="color: grey">(49ad484)</span></li>
<li>filters/libmsooxml/MsooXmlTheme.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmsooxml/MsooXmlThemesReader.h <span style="color: grey">(9682c34)</span></li>
<li>filters/libmsooxml/MsooXmlThemesReader.cpp <span style="color: grey">(5335029)</span></li>
<li>filters/libmsooxml/MsooXmlUtils.h <span style="color: grey">(055fa15)</span></li>
<li>filters/libmsooxml/MsooXmlUtils.cpp <span style="color: grey">(31df41e)</span></li>
<li>filters/libodf2/CMakeLists.txt <span style="color: grey">(3792771)</span></li>
<li>filters/libodf2/chart/Charting.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/chart/KoOdfChartWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/chart/KoOdfChartWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/chart/PLAN <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/sheets/excel/export/CMakeLists.txt <span style="color: grey">(acc5a73)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: grey">(de653ee)</span></li>
<li>filters/sheets/excel/import/ExcelImport.cpp <span style="color: grey">(abf4c52)</span></li>
<li>filters/sheets/excel/import/excelimporttoods.cc <span style="color: grey">(5d6887b)</span></li>
<li>filters/sheets/excel/sidewinder/CMakeLists.txt <span style="color: grey">(097e2a8)</span></li>
<li>filters/sheets/excel/sidewinder/chartsubstreamhandler.h <span style="color: grey">(d22c02b)</span></li>
<li>filters/sheets/excel/sidewinder/chartsubstreamhandler.cpp <span style="color: grey">(ecd9071)</span></li>
<li>filters/sheets/excel/sidewinder/objects.h <span style="color: grey">(5162cee)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: grey">(294f048)</span></li>
<li>filters/sheets/xlsx/ChartExport.h <span style="color: grey">(aa9895d)</span></li>
<li>filters/sheets/xlsx/ChartExport.cpp <span style="color: grey">(27b075b)</span></li>
<li>filters/sheets/xlsx/Charting.h <span style="color: grey">(4fea470)</span></li>
<li>filters/sheets/xlsx/NumberFormatParser.h <span style="color: grey">(e877d40)</span></li>
<li>filters/sheets/xlsx/NumberFormatParser.cpp <span style="color: grey">(433ffe8)</span></li>
<li>filters/sheets/xlsx/XlsxChartOdfWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/sheets/xlsx/XlsxChartOdfWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/sheets/xlsx/XlsxImport.cpp <span style="color: grey">(b0091ca)</span></li>
<li>filters/sheets/xlsx/XlsxUtils.h <span style="color: grey">(2858ce4)</span></li>
<li>filters/sheets/xlsx/XlsxXmlChartReader.h <span style="color: grey">(a2b07e8)</span></li>
<li>filters/sheets/xlsx/XlsxXmlChartReader.cpp <span style="color: grey">(0434961)</span></li>
<li>filters/sheets/xlsx/XlsxXmlCommentsReader.h <span style="color: grey">(e025a06)</span></li>
<li>filters/sheets/xlsx/XlsxXmlCommonReader.h <span style="color: grey">(e406b0a)</span></li>
<li>filters/sheets/xlsx/XlsxXmlDocumentReader.h <span style="color: grey">(6395799)</span></li>
<li>filters/sheets/xlsx/XlsxXmlDocumentReader.cpp <span style="color: grey">(a4961ee)</span></li>
<li>filters/sheets/xlsx/XlsxXmlDrawingReader.h <span style="color: grey">(69c75ac)</span></li>
<li>filters/sheets/xlsx/XlsxXmlDrawingReader.cpp <span style="color: grey">(def1ff6)</span></li>
<li>filters/sheets/xlsx/XlsxXmlStylesReader.h <span style="color: grey">(4793ae3)</span></li>
<li>filters/sheets/xlsx/XlsxXmlWorksheetReader.h <span style="color: grey">(559a029)</span></li>
<li>filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp <span style="color: grey">(74e1302)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(36434f9)</span></li>
<li>filters/stage/pptx/PptxXmlSlideReader.cpp <span style="color: grey">(702a381)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(70490d4)</span></li>
<li>filters/words/docx/import/DocxXmlDocumentReader.h <span style="color: grey">(bfb9171)</span></li>
<li>filters/words/docx/import/DocxXmlDocumentReader.cpp <span style="color: grey">(ae7cb0e)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(2b975a1)</span></li>
<li>CMakeLists.txt <span style="color: grey">(1f992dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122045/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>