<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122053/">https://git.reviewboard.kde.org/r/122053/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Your solution is a workaround - 1. we would need add the shortcut by hand for every use of the table view, and 2. we wouldn't have global shortcut available for configuration by users.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, based on your other patch (for CTRL+F5) I tried this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">--- kexi/widget/dataviewcommon/kexidataawareview.cpp
+++ kexi/widget/dataviewcommon/kexidataawareview.cpp
@@ -130,6 +130,7 @@ void KexiDataAwareView::initActions()
plugSharedAction("data_cancel_row_changes", this, SLOT(cancelRowEdit()));
d->actionClient->plugSharedAction(sharedAction("data_cancel_row_changes")); //for proper shortcut
d->actionClient->plugSharedAction(sharedAction("edit_insert_empty_row")); //for proper shortcut
+ addAction(sharedAction("edit_insert_empty_row"));</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> setAvailable(<span style="color: #BA2121">"data_sort_az"</span>, d<span style="color: #666666">-></span>dataAwareObject<span style="color: #666666">-></span>isSortingEnabled());
setAvailable(<span style="color: #BA2121">"data_sort_za"</span>, d<span style="color: #666666">-></span>dataAwareObject<span style="color: #666666">-></span>isSortingEnabled());
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">...and it works - both in table and query designer. However we wouldn't need to explicitly call addAction() this way.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's leave this unresolved for a while so I'll look how to improve the overall API without workarounds. Looks like this would be ultimate fix, shared actions come from Qt 3 era.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks.</p></pre>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On January 14th, 2015, 2:19 p.m. CET, Roman Shtemberko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Roman Shtemberko.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2015, 2:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=338832">338832</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=338833">338833</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://bugs.kde.org/show_bug.cgi?id=338832</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shortcut works as expected in both Table and Query Design views.
However, shortcut tip is not showed in the right-click menu.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(f499951)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>