<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121938/">https://git.reviewboard.kde.org/r/121938/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2015, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Properly merge geometry record navigator with horizontal scrollbar</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This also fixes navigator updating on selecting another record (by mouse click or keyboard navigation).
-- major defect #1 at https://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+ Do not display the scrollbar when not needed.
+ Remove related code that's no longer needed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked with tables/queries/forms/reports and various styles</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(97ee885a97744f35bfdd140488e8ac4414153d13)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(f4a2dfe13b51a4305b019ddd917a00015583e31f)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(d76097bb52d358fcd7430ab80857ba9617764a6f)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.h <span style="color: grey">(a0cf2546c0dfd165f14b36005ac6cca5d2d72217)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.cpp <span style="color: grey">(0ce922a3ef2229cdefde032a1660de9fb05439c9)</span></li>
<li>kexi/core/KexiRecordNavigatorIface.h <span style="color: grey">(5cf616f32584780311aa9b2c94e07274cc07272f)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(82910f56147b01923e063fd25a694858d6f867dd)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(4c563725a38381356013835a65ff02133c04c7eb)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: grey">(60c27e0ae4b0653e99dbdc209a072c51a90d620c)</span></li>
<li>kexi/plugins/reports/kexireportview.cpp <span style="color: grey">(58d97052280f6aa048946edf43be40b470b343fd)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(74ab76f39005cc06f8889d67fff5a40304afba8f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121938/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/806686d1-7680-434a-b2be-52a3b03a1275__d7AloPW.png">The navigator</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>