<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121874/">https://git.reviewboard.kde.org/r/121874/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems okay :)</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121874/diff/1/?file=338503#file338503line42" style="color: black; font-weight: bold; text-decoration: underline;">kexi/core/kexi.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KIconTheme></span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KMimeType></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Boud once for some reason I forgot (possible incomplete forward headers) standardized all kdelibs includes in Calligra to use the real headers.
For consistency I would propose to keep it like that (perhaps start changing in the qt5/kf5 port then).</p></pre>
</div>
</div>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On Januar 5th, 2015, 9:41 nachm. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2015, 9:41 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Improve major icons and introduce KexiIcon: icon name as understood by Kexi</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These improvements prepare Kexi to be more attractive on Windows and Mac, I believe. See the screenshot.
Kexi 3 hopefully won't have to do most of this, but we never know.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icon theme support is improved this way. The problem solved here is that for kdelibs4 oxygen is the default theme and cannot be overriden by app by just installing to ../share/apps/kexi/icons/THEMENAME/...
So breeze- prefix temporarily is used and theme is detected. Also quality of HighContrast-themed Kexi is improved this way.
Functions are used for some icon names instead of constants because names are computed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons improved:
- database-import (temporarily re-use document-import for breeze)
- network-server-database (breeze)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons added:
- kexi-document-empty (made more concrete than document-new)
- kexi-file-database (replaces kexi-sqlite3 mime icon for breeze because the original is unreadable in our context, elsewhere mime icon still used)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons changed:
- use app-x-compress for 'compact' action</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked oxygen, breeze, and a few other themes, plus all relevant GUIs</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/pics/oxygen/32x32/actions/kexi-document-empty.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/32x32/places/breeze-kexi-file-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/32x32/actions/kexi-document-empty.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/16x16/places/breeze-network-server-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/22x22/actions/breeze-database-import.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/22x22/actions/breeze-kexi-document-empty.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/22x22/places/breeze-kexi-file-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/22x22/places/breeze-network-server-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/32x32/actions/breeze-kexi-document-empty.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/16x16/places/breeze-kexi-file-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/hi48-action-database-import.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/hi48-action-document_import_database.png <span style="color: grey">(da63b43b335691ee0df9569f727e4cf033b223ab)</span></li>
<li>kexi/pics/hi22-action-document_import_database.png <span style="color: grey">(18238ee33bf7e1785ab4f9e36003690f98aac27f)</span></li>
<li>kexi/pics/hi32-action-database-import.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/hi32-action-document_import_database.png <span style="color: grey">(dd9368984d0a3356144b8710d75e6eff56edcdf8)</span></li>
<li>kexi/pics/hi16-action-database-import.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/hi16-action-document_import_database.png <span style="color: grey">(e3a5398d452dc60e5fdc134f671c97d76aa256a7)</span></li>
<li>kexi/pics/hi22-action-database-import.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/importwizard.cpp <span style="color: grey">(226561b92194e67fc49c0fcf3fe702eb5ebdac54)</span></li>
<li>kexi/main/startup/KexiStartupDialog.cpp <span style="color: grey">(e5b13dcbb32d20a6b602d9d8f4d90ac6be1b604e)</span></li>
<li>kexi/main/startup/KexiRecentProjectsModel.cpp <span style="color: grey">(6eb1b296c41130b18928d33f8acab28e45e78ddf)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(e3bb54e42798efff0e05b387c88cc091c6b4ad67)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.cpp <span style="color: grey">(4c7bf4842cdecc8e2694e58d8fb5c81247c6d409)</span></li>
<li>kexi/main/startup/KexiOpenProjectAssistant.cpp <span style="color: grey">(518098fa62a11cc1f57dcdd846a9918b894dec51)</span></li>
<li>kexi/core/kexitemplateloader.cpp <span style="color: grey">(0969f17c844c476c3184218211a16a71a650020d)</span></li>
<li>kexi/core/kexi.cpp <span style="color: grey">(65ad365a666ccd8b0e28e3d254c9c3b1defad9ed)</span></li>
<li>kexi/core/kexi.h <span style="color: grey">(10d27cc77aab3a072d5262648ab8b292e7418c11)</span></li>
<li>libs/db/utils.h <span style="color: grey">(2952c615ac1723e2e4ebf3230219e769f1b9bbaf)</span></li>
<li>libs/db/utils.cpp <span style="color: grey">(b0704d30ce8e594e4911f97c6f05877b543dffd9)</span></li>
<li>kexi/pics/oxygen/32x32/places/breeze-network-server-database.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/48x48/actions/kexi-document-empty.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/oxygen/64x64/actions/kexi-document-empty.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiConnectionSelectorWidget.cpp <span style="color: grey">(458c9a3322bb6063500872525c0631b315eceb57)</span></li>
<li>kexi/widget/KexiProjectSelectorWidget.cpp <span style="color: grey">(ad01ee22e7437c4a21e3f4a7440c8d9338ac3ee9)</span></li>
<li>kexi/widget/kexidbconnectionwidget.cpp <span style="color: grey">(9f780efdda79e020344089e58e411ada38600bd1)</span></li>
<li>kexi/widget/kexiprjtypeselector.cpp <span style="color: grey">(a331f0d39d3f956b4d87f26959cb85f2fb2be27c)</span></li>
<li>kexi/widget/navigator/KexiProjectNavigator.cpp <span style="color: grey">(2c0a536d7baa8cdf2778c0dc0df52749571f13a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121874/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/05/252a3b9a-02cd-40d2-9584-143d401c2b71__kexi-2.9-breeze-icons.png">Welcome Screen with refreshed icons</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>