<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120935/">https://git.reviewboard.kde.org/r/120935/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2015, 9:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed comments</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added a new property to the following report items:
check
field
text
barcode
Renamed image property 'Static Image' to Value but left saving/loading the same for compatibility.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added a method to KoReportDesignerItemRectBase to store a string used for rendering data in the report designer.
Report designer shows the static data if used</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Includes a bug fix in KRSize which meant recursion was possible
Includes a small fix to Text item which caused an infinite loop.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loading/saving each item type
Testing each type with:
value set, value not set and data source set, data source set and value set</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Items display correctly in designer</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/items/field/KoReportItemField.cpp <span style="color: grey">(e2ce309)</span></li>
<li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(af4925f)</span></li>
<li>libs/koreport/items/image/KoReportItemImage.cpp <span style="color: grey">(286225f)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.h <span style="color: grey">(6822ee8)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(f656dc3)</span></li>
<li>libs/koreport/items/text/KoReportItemText.h <span style="color: grey">(d843aa8)</span></li>
<li>libs/koreport/items/text/KoReportItemText.cpp <span style="color: grey">(d6296bd)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemBase.h <span style="color: grey">(5d43131)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp <span style="color: grey">(a542e87)</span></li>
<li>plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp <span style="color: grey">(5d38862)</span></li>
<li>plugins/reporting/barcode/KoReportItemBarcode.h <span style="color: grey">(0189f96)</span></li>
<li>plugins/reporting/barcode/KoReportItemBarcode.cpp <span style="color: grey">(d7d9278)</span></li>
<li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(01b5f1c)</span></li>
<li>libs/koreport/items/check/KoReportItemCheck.h <span style="color: grey">(fafe2c4)</span></li>
<li>libs/koreport/items/check/KoReportItemCheck.cpp <span style="color: grey">(224a744)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(6910224)</span></li>
<li>libs/koreport/items/field/KoReportItemField.h <span style="color: grey">(26080f3)</span></li>
<li>libs/koreport/common/krsize.h <span style="color: grey">(cc319c0)</span></li>
<li>libs/koreport/common/krsize.cpp <span style="color: grey">(f8c0d7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120935/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>