<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121625/">https://git.reviewboard.kde.org/r/121625/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2014, 10:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed all requests except the penPixmap() one, see comment.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally! A port that took 6 months, now largely functional. Changes are so cross-dependent, it's hard to split to smaller patches that result in something stable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes along the way:
* Harmonize API related to sorting with the Qt API
* Port and clean up current column highlighting
* Make shortcuts work
* Make arrow keys ignore modifiers
* Ensure the current cell is visible before trying to remove current record
* Use separate macro for enabling painting debug
* Use row, then col as args in cellSelected() and paintCell() methods (per convention of Qt)
This also fixes on ensureCellVisible() call when the args where swapped by mistake.
* If possible don't move pos of current selection after sorting
* Rename record -> row in table view for more generic API
* Clicking on vertical header selects row
* Hovering on vertical header highlights row
* Display current record pointer as icon
* Show mouse highlight in the vertical header when needed
* Support leave event
* Fix sizes and buttons in record navigator
* Make parameter names consistent
* Fix column resizing, column sorting, painting on scroll
* Fix initializing widths of table columns
* Remove unused variable and excessive debug
* Put horizontal scrollbar aside of the record navigator when possible (but don't cover the navigator)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New features:
* Lighter style of rows
* Display "key" icon in primary key columns</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on tables and query designer: functional</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/tableview/kexidatatable.cpp <span style="color: grey">(f75e736)</span></li>
<li>kexi/widget/tableview/kexidatatableview.h <span style="color: grey">(53f2a61)</span></li>
<li>kexi/widget/tableview/kexiblobtableedit.cpp <span style="color: grey">(bece46f)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.cpp <span style="color: grey">(d64439d)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.h <span style="color: grey">(d08ece2)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(4eba57b)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(2ee4a0c)</span></li>
<li>kexi/widget/tableview/kexidatatable.h <span style="color: grey">(b64cbb7)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableScrollArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/kexidatatableview.cpp <span style="color: grey">(62c8760)</span></li>
<li>kexi/widget/tableview/kexitableedit.h <span style="color: grey">(6da77e3)</span></li>
<li>kexi/widget/tableview/kexitableedit.cpp <span style="color: grey">(ff44b7c)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(86e5446)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(492b8a8)</span></li>
<li>kexi/widget/tableview/kexitableview_p.h <span style="color: grey">(38fae7b)</span></li>
<li>kexi/widget/tableview/kexitableview_p.cpp <span style="color: grey">(1f64f52)</span></li>
<li>kexi/widget/tableview/kexitableviewheader.h <span style="color: grey">(1201f2b)</span></li>
<li>kexi/widget/tableview/kexitableviewheader.cpp <span style="color: grey">(fcf3ade)</span></li>
<li>kexi/widget/utils/CMakeLists.txt <span style="color: grey">(6942aaa)</span></li>
<li>kexi/widget/utils/kexirecordmarker.h <span style="color: grey">(db024f2)</span></li>
<li>kexi/widget/utils/kexirecordmarker.cpp <span style="color: grey">(5ed82e4)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.h <span style="color: grey">(7bb8b12)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.cpp <span style="color: grey">(dd47b2c)</span></li>
<li>libs/db/tableviewcolumn.h <span style="color: grey">(f2370bc)</span></li>
<li>libs/db/tableviewcolumn.cpp <span style="color: grey">(0687b0b)</span></li>
<li>libs/db/tableviewdata.h <span style="color: grey">(42523c4)</span></li>
<li>libs/db/tableviewdata.cpp <span style="color: grey">(e4660a0)</span></li>
<li>kexi/plugins/tables/kexitabledesigner_dataview.cpp <span style="color: grey">(34ae4ef)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.h <span style="color: grey">(cfec74b)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(7aca480)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.h <span style="color: grey">(c52bd0b)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(9b2dcbd)</span></li>
<li>kexi/plugins/tables/kexitablepart.cpp <span style="color: grey">(b8fd0d7)</span></li>
<li>kexi/tests/newapi/tableview_test.h <span style="color: grey">(092c2ff)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(fe8a2de)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(948ba5d)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.h <span style="color: grey">(a131b89)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(779b24e)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.h <span style="color: grey">(6604bd2)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(5473ec7)</span></li>
<li>kexi/widget/tableview/CMakeLists.txt <span style="color: grey">(24e1cf1)</span></li>
<li>kexi/widget/tableview/KexiDataTableScrollArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(9538688)</span></li>
<li>kexi/plugins/queries/kexiqueryview.h <span style="color: grey">(b987d81)</span></li>
<li>kexi/plugins/queries/kexiqueryview.cpp <span style="color: grey">(2206214)</span></li>
<li>kexi/plugins/reports/kexireportview.cpp <span style="color: grey">(047f949)</span></li>
<li>kexi/plugins/tables/kexitabledesigner_dataview.h <span style="color: grey">(ea9aba0)</span></li>
<li>kexi/pics/tableview_plus.xpm <span style="color: grey">(de7019b)</span></li>
<li>kexi/pics/tableview_pointer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/tableview_pointer.xpm <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(b9ce947)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(f4aa2e2)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(fbfa560)</span></li>
<li>kexi/plugins/forms/kexiformview.h <span style="color: grey">(2932861)</span></li>
<li>kexi/pics/tableview_plus.png <span style="color: grey">(bc858050cf2bd3bb6d83f4b590817074e816658c)</span></li>
<li>kexi/pics/tableview_pen.xpm <span style="color: grey">(3d2bd3e)</span></li>
<li>kexi/pics/tableview_pen.png <span style="color: grey">(f91eacf63e604300ca563a48bd749cde5d33cb6c)</span></li>
<li>kexi/CMakeLists.txt <span style="color: grey">(55eac5b)</span></li>
<li>kexi/formeditor/connectiondialog.h <span style="color: grey">(627499e)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(469e78a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121625/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>