<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121625/">https://git.reviewboard.kde.org/r/121625/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not yet give a detailed testing, noted one issue (see wiki) while giving it a shoot though.
Skimmed code at least a little, a few comments here.
Hopefully can give some more time the next days. Perhaps still good enough to merge already and fix remaining issues in 2.9 branch, given it basically seems to work.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335075#file335075line41" style="color: black; font-weight: bold; text-decoration: underline;">kexi/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">IF</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">IF</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ELSE</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ELSE</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_definitions</span><span class="p">(</span><span class="s">-DQT3_SUPPORT</span> <span class="s">-DQT3_SUPPORT_WARNINGS</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ENDIF</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">ENDIF</span><span class="p">(</span><span class="s">KEXI_MOBILE</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IF ENDIF Can be completely removed</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335086#file335086line58" style="color: black; font-weight: bold; text-decoration: underline;">kexi/plugins/forms/kexiformscrollview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">,</span> <span class="n">localSortingOrder</span><span class="p"><span class="hl">(</span></span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p">)</span> <span class="cm">/* no sorting */</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">,</span> <span class="n">localSort<span class="hl">Order</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">Qt</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Ascend</span>ingOrder</span><span class="p">)</span> <span class="cm">/* no sorting */</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Comment "no sorting" no longer true, so better remove.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335120#file335120line58" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/tableview/KexiTableScrollArea_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">horizontalHeader</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why setting to 0? Seems unneeded in deconstructor and unusual, could get a comment why it is done (or be removed).</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335141#file335141line114" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/utils/kexirecordnavigator.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">QPixmap</span> <span class="nf">penPixmap</span><span class="p">(</span><span class="k">const</span> <span class="n">QPalette</span> <span class="o">&</span><span class="n">palette</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, why QPixmap and not QIcon? Multiple places might want different scales of the icon, also at runtime, when the UI is adapted at runtime to a different display device perhaps.
Also not sure if the navigator class should be owner of these icons/pismaps, perhaps some own namespace area would be better, so UIs not using objects of the navigator class can just ignore the class.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335142#file335142line105" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/utils/kexirecordnavigator.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">putAsideOfHorizontalScrollBar</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">putAside...</code> sounds like an action, perhaps better <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">isAside...</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335142#file335142line638" style="color: black; font-weight: bold; text-decoration: underline;">kexi/widget/utils/kexirecordnavigator.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiRecordNavigator::insertAsideOfHorizontalScrollBar(QAbstractScrollArea *area)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KexiRecordNavigator::putAsideOfHorizontalScrollBar(QAbstractScrollArea *area, bool put)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">576</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KexiRecordNavigator</span><span class="o">::</span><span class="n"><span class="hl">inser</span>tAsideOfHorizontalScrollBar</span><span class="p">(</span><span class="n">QAbstractScrollArea</span> <span class="o">*</span><span class="n">area</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">585</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KexiRecordNavigator</span><span class="o">::</span><span class="n"><span class="hl">pu</span>tAsideOfHorizontalScrollBar</span><span class="p">(</span><span class="n">QAbstractScrollArea</span> <span class="o">*</span><span class="n">area</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">put</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For a nice API, instead of being of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">bool</code> type, the var <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">put</code> ideally would be an enum and also named <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">position</code>.
Method could be named <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">setPositionRelativeToHorizontalScrollBar</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121625/diff/1/?file=335146#file335146line563" style="color: black; font-weight: bold; text-decoration: underline;">libs/db/tableviewdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const ResultInfo& TableViewData::result() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">486</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">ascendingOrder</span> <span class="o">=</span> <span class="n">ascending</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">545</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">column</span> <span class="o">>=</span> <span class="mi">0</span> <span class="o">&&</span> <span class="n">column</span> <span class="o"><</span> <span class="n">d</span><span class="o">-></span><span class="n">columns</span><span class="p">.</span><span class="n">count</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For simpler to read code better invert condition and remove empty first branch:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #408080; font-style: italic">// no such column?</span>
<span style="color: #008000; font-weight: bold">if</span> (column <span style="color: #666666"><</span> <span style="color: #666666">0</span> <span style="color: #666666">||</span> column <span style="color: #666666">>=</span> d<span style="color: #666666">-></span>columns.count()) {
d<span style="color: #666666">-></span>sortColumn <span style="color: #666666">=</span> <span style="color: #666666">-1</span>;
d<span style="color: #666666">-></span>realSortColumn <span style="color: #666666">=</span> <span style="color: #666666">-1</span>;
<span style="color: #008000; font-weight: bold">return</span>;
}
</pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On Dezember 21st, 2014, 10:27 nachm. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Dez. 21, 2014, 10:27 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally! A port that took 6 months, now largely functional. Changes are so cross-dependent, it's hard to split to smaller patches that result in something stable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes along the way:
* Harmonize API related to sorting with the Qt API
* Port and clean up current column highlighting
* Make shortcuts work
* Make arrow keys ignore modifiers
* Ensure the current cell is visible before trying to remove current record
* Use separate macro for enabling painting debug
* Use row, then col as args in cellSelected() and paintCell() methods (per convention of Qt)
This also fixes on ensureCellVisible() call when the args where swapped by mistake.
* If possible don't move pos of current selection after sorting
* Rename record -> row in table view for more generic API
* Clicking on vertical header selects row
* Hovering on vertical header highlights row
* Display current record pointer as icon
* Show mouse highlight in the vertical header when needed
* Support leave event
* Fix sizes and buttons in record navigator
* Make parameter names consistent
* Fix column resizing, column sorting, painting on scroll
* Fix initializing widths of table columns
* Remove unused variable and excessive debug
* Put horizontal scrollbar aside of the record navigator when possible (but don't cover the navigator)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New features:
* Lighter style of rows
* Display "key" icon in primary key columns</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on tables and query designer: functional</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/utils/CMakeLists.txt <span style="color: grey">(6942aaa)</span></li>
<li>kexi/widget/utils/kexirecordmarker.h <span style="color: grey">(db024f2)</span></li>
<li>kexi/widget/utils/kexirecordmarker.cpp <span style="color: grey">(5ed82e4)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.h <span style="color: grey">(7bb8b12)</span></li>
<li>kexi/widget/tableview/kexitableedit.cpp <span style="color: grey">(ff44b7c)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(86e5446)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(492b8a8)</span></li>
<li>kexi/widget/tableview/kexitableview_p.h <span style="color: grey">(38fae7b)</span></li>
<li>kexi/widget/tableview/kexitableview_p.cpp <span style="color: grey">(1f64f52)</span></li>
<li>kexi/widget/tableview/kexitableviewheader.h <span style="color: grey">(1201f2b)</span></li>
<li>kexi/widget/tableview/kexitableviewheader.cpp <span style="color: grey">(fcf3ade)</span></li>
<li>kexi/plugins/tables/kexitabledesigner_dataview.cpp <span style="color: grey">(34ae4ef)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.h <span style="color: grey">(cfec74b)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: grey">(7aca480)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.h <span style="color: grey">(c52bd0b)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview_p.cpp <span style="color: grey">(9b2dcbd)</span></li>
<li>kexi/plugins/tables/kexitablepart.cpp <span style="color: grey">(b8fd0d7)</span></li>
<li>kexi/tests/newapi/tableview_test.h <span style="color: grey">(092c2ff)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.h <span style="color: grey">(fe8a2de)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp <span style="color: grey">(948ba5d)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.h <span style="color: grey">(a131b89)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(779b24e)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.h <span style="color: grey">(6604bd2)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(5473ec7)</span></li>
<li>kexi/widget/tableview/CMakeLists.txt <span style="color: grey">(24e1cf1)</span></li>
<li>kexi/widget/tableview/KexiDataTableScrollArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableScrollArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiDataTableView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollAreaWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/KexiTableScrollArea_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/widget/tableview/kexiblobtableedit.cpp <span style="color: grey">(bece46f)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.cpp <span style="color: grey">(d64439d)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.h <span style="color: grey">(d08ece2)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(4eba57b)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(2ee4a0c)</span></li>
<li>kexi/widget/tableview/kexidatatable.h <span style="color: grey">(b64cbb7)</span></li>
<li>kexi/widget/tableview/kexidatatable.cpp <span style="color: grey">(f75e736)</span></li>
<li>kexi/widget/tableview/kexidatatableview.h <span style="color: grey">(53f2a61)</span></li>
<li>kexi/widget/tableview/kexidatatableview.cpp <span style="color: grey">(62c8760)</span></li>
<li>kexi/widget/tableview/kexitableedit.h <span style="color: grey">(6da77e3)</span></li>
<li>kexi/formeditor/connectiondialog.h <span style="color: grey">(627499e)</span></li>
<li>kexi/formeditor/connectiondialog.cpp <span style="color: grey">(469e78a)</span></li>
<li>kexi/pics/tableview_pen.png <span style="color: grey">(f91eacf63e604300ca563a48bd749cde5d33cb6c)</span></li>
<li>kexi/pics/tableview_pen.xpm <span style="color: grey">(3d2bd3e)</span></li>
<li>kexi/pics/tableview_plus.png <span style="color: grey">(bc858050cf2bd3bb6d83f4b590817074e816658c)</span></li>
<li>kexi/pics/tableview_plus.xpm <span style="color: grey">(de7019b)</span></li>
<li>kexi/pics/tableview_pointer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/pics/tableview_pointer.xpm <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/plugins/forms/CMakeLists.txt <span style="color: grey">(b9ce947)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.h <span style="color: grey">(f4aa2e2)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(fbfa560)</span></li>
<li>kexi/plugins/forms/kexiformview.h <span style="color: grey">(2932861)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(9538688)</span></li>
<li>kexi/plugins/queries/kexiqueryview.h <span style="color: grey">(b987d81)</span></li>
<li>kexi/plugins/queries/kexiqueryview.cpp <span style="color: grey">(2206214)</span></li>
<li>kexi/plugins/reports/kexireportview.cpp <span style="color: grey">(047f949)</span></li>
<li>libs/db/tableviewcolumn.cpp <span style="color: grey">(0687b0b)</span></li>
<li>libs/db/tableviewdata.h <span style="color: grey">(42523c4)</span></li>
<li>libs/db/tableviewdata.cpp <span style="color: grey">(e4660a0)</span></li>
<li>kexi/widget/utils/kexirecordnavigator.cpp <span style="color: grey">(dd47b2c)</span></li>
<li>libs/db/tableviewcolumn.h <span style="color: grey">(f2370bc)</span></li>
<li>kexi/plugins/tables/kexitabledesigner_dataview.h <span style="color: grey">(ea9aba0)</span></li>
<li>kexi/CMakeLists.txt <span style="color: grey">(55eac5b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121625/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>