<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121541/">https://git.reviewboard.kde.org/r/121541/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Cyrille Berger Skott, Boudewijn Rempt, and Jarosław Staniek.</div>
<div>By Friedrich W. H. Kossebau.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before starting the Qt5/KF5 port, apply this patch as the first when having branched off the branch where the port work shall happen. It will help controlling what is build and what not, using all the powers of the product set system.
No need to uncomment all kind of cmake lines and mess with internal deps, just control by the "UNPORTED" tags.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It will remove all products/features from the build which have the tag "UNPORTED" in their definition right after the name (at least before the "REQUIRES" section). Initially this patch will set the tag to all products & features, so that the stuff to build after running cmake will be an empty list.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So once you start working on the port of another product, remove the "UNPORTED" tag for it, so it gets into the list of things to build. To overrule/ignore the "UNPORTED" tags, pass -DBUILD_UNPORTED=1 to cmake.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any ideas where this approach could be improved? Tell me, happy to shape things to aid porting efforts some more.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CalligraProducts.cmake <span style="color: grey">(72946c7)</span></li>
<li>cmake/modules/CalligraProductSetMacros.cmake <span style="color: grey">(8b0492b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121541/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>