<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121389/">https://git.reviewboard.kde.org/r/121389/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2014, 12:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-> 2.9</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=340768">340768</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Newly created project shouldn't use window of previously opened project</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unlike in 2.8 (https://git.reviewboard.kde.org/r/121321/) in case of server projects
we're starting a new Kexi instance and pass connection data file to its
--connection option and database name.
In case of file projects we're passing absolute file path.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As a side effect, a number of internal APIs improved:
- use const refs when reasonable
- keep relations between connection and its filename based on string key instead of pointer (so deep copies are allowed)
- removed some unused routines</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works OK for any combination of file/server projects</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/importwizard.cpp <span style="color: grey">(7dae2f639511d1cafb98da33cc3b5840acad3b1d)</span></li>
<li>kexi/widget/KexiConnectionSelectorWidget.cpp <span style="color: grey">(aeef8ba746fa7f015c2bf18965e134d1d973c597)</span></li>
<li>kexi/core/KexiRecentProjects.h <span style="color: grey">(a22a40ea071d5a78dd9aa710f3bf2d4518af0da9)</span></li>
<li>kexi/core/KexiRecentProjects.cpp <span style="color: grey">(eda7070d6f40589bf5b9a7f8d52cf4f4e58082ca)</span></li>
<li>kexi/core/kexidbconnectionset.h <span style="color: grey">(686355bff2a023e6df4d222eec80ecc47329858e)</span></li>
<li>kexi/core/kexidbconnectionset.cpp <span style="color: grey">(a0616f0abbcca6d75e907a585cd19ead1022f1d3)</span></li>
<li>kexi/main/KexiMainWindow.h <span style="color: grey">(fa46b1215676ade8fafbdc3708bcf44aedb96d68)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(e43d4d88857785aae7dec9a1e7be3a458d0da237)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.h <span style="color: grey">(25b4705b303966e14c1e5db7cc3126d62cf2f5bf)</span></li>
<li>kexi/main/startup/KexiNewProjectAssistant.cpp <span style="color: grey">(78a3e08c6248a18a2c1d150676fe0bcf1118846e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121389/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>