<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121380/">https://git.reviewboard.kde.org/r/121380/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks -- the only niggle is that if we manage to get the dropshadow layer effect working, the dropshadow plugin will be deleted :-)</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On December 7th, 2014, 2:48 p.m. UTC, Stefano Bonicatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stefano Bonicatti.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2014, 2:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix some memory leaks around the code, found thanks to cppcheck.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kis_datamanager_benchmark.cpp and kis_compression_tests.cpp: even if maybe they aren't used, better be safe than sorry.
kis_brush.cpp: a simple mismatch in the new/delete.
kis_dropshadow.cc: sum pointer is leaking by pointing at new memory without freeing it first. The function too exits without freeing sum new memory. I've removed the switches because delete[] makes a null check anyway so there's no issue and if in the future someone changes code to allocate those in other cases, they won't leak.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiling against master.
Rerun cppcheck and issues are gone.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/benchmarks/kis_datamanager_benchmark.cpp <span style="color: grey">(b565abf)</span></li>
<li>krita/image/tiles3/tests/kis_compression_tests.cpp <span style="color: grey">(505986b)</span></li>
<li>krita/libbrush/kis_brush.cpp <span style="color: grey">(4cb0e36)</span></li>
<li>krita/plugins/extensions/dropshadow/kis_dropshadow.cc <span style="color: grey">(388b8f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121380/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>