<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121156/">https://git.reviewboard.kde.org/r/121156/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 25th, 2014, 1:04 a.m. CET, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Interesting idea with the What's this button, can imagine that this improves things for users. Seems good to me to go in.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it following some UI pattern? Ideally something that will be consistenly solved in other apps as well?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks! As you can recall it's based on what we see in web sites' forms. In traditional KDE dialogs it's noticeable that the Help button is old-school and context-less, and What's This tool isn't very helpful - user never know if there's help available for given UI element, usualy it is not. Here we have a clear hint for more complicated UI part.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not a pattern of the KDE HIG for now but I can propose it to the VDG where I am contributing recently as well - https://forum.kde.org/viewforum.php?f=285
Ideally the icon + context would be available in ready to use API one day.</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On November 17th, 2014, 7:42 p.m. CET, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2014, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify "Save password" checkbox text but add direct what's this button
+ improve layout and tab order</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dialog improved, overall features the same</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/kexidbconnectionwidget.h <span style="color: grey">(14e49004d87a2977616fe869d2f0ea0b2c545bc1)</span></li>
<li>kexi/widget/kexidbconnectionwidget.cpp <span style="color: grey">(5345beabc28591dec918d8212bb494166e970ac2)</span></li>
<li>kexi/widget/kexidbconnectionwidget.ui <span style="color: grey">(f78f27ef9ce70cfaf626188a89bcf9b8a971d42b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121156/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/17/e666191e-2f5c-4d2b-ae45-45b5fc34c4d7__savepwd.png">The dialog with the What's This box</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>