<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121214/">https://git.reviewboard.kde.org/r/121214/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann, Dan Leinir Turthra Jensen, and Yue Liu.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2014, 3:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some of my files with native ODF graphics inside are badly rendered by Calligra programs, e.g. the logo of KO: http://heap.kogmbh.net/friedrich/kologo.odt</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Investigating onto proper SVG paths and comparing with LO and Inkscape I found that 501f4d55d0828b7a9ca1c62500454358feb4a0b1 was the culprit here, as the problem mentioned in https://bugs.kde.org/show_bug.cgi?id=297981 was actually due to a bug in LO, which has been meanwhiled fixed and also was accompagnied by an update of the paths of the installed markers from LO, so that fix was only copying a bug, breaking otherwise fine code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So this diff consists of three commits:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> revert 501f4d55d0828b7a9ca1c62500454358feb4a0b1
</em> sync preinstalled marker with those of current LibreOffice
* catch old marker paths on loading</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For me this PR fixes the rendering of my files, like the one linked above, and also of files created with a recent LO where arrows have been added with unfilled markers (e.g. diamond) at their end. Files created with Calligra programs before that also use arrows with markers still load fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would like to backport to 2.8 in time for 2.8.7, so please give it a quick review.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoMarker.cpp <span style="color: grey">(419f4e6)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(3f64741)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(5a43200)</span></li>
<li>libs/flake/KoPathShapeLoader.cpp <span style="color: grey">(0f8a4ad)</span></li>
<li>libs/flake/styles/markers.xml <span style="color: grey">(c3e7cfa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121214/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>