<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121123/">https://git.reviewboard.kde.org/r/121123/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Dan Leinir Turthra Jensen</p>
<br />
<p>On November 14th, 2014, 6:48 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann, Inge Wallin, Dan Leinir Turthra Jensen, and Thorsten Zachmann.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2014, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently thumbnails for ODT files etc. are generated using the configured view settings (incl. showing non-existing table borders, annotations, textshape outlines, inlineobjects highlight, etc). IMHO pure thumbnails used for previews outside of the editor app should just render pages like for print, and only inside editor apps (e.g. when used for page overview widgets) the thumbnails should be resembling the current display of the page in the editor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Attached patch enables this, by adding a parameter to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KWPage::thumbnail(...)</code> which allows to control how the rendering of thumbnails is done.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes the preview thumbnails as generated for ODT files, both for embedding into the file but also when generating previews in the filemanager with the thumbnailer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure about <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CSThumbProviderWords::createThumbnails(...)</code> from cstester though. Thorsten, which rendering should be done there? As for print, or as for whatever is configured for the editor view?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>extras/okularodtgenerator/OkularOdtGenerator.cpp <span style="color: grey">(d1b98a5)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(e287829)</span></li>
<li>words/part/KWPage.h <span style="color: grey">(0821ccd)</span></li>
<li>words/part/KWPage.cpp <span style="color: grey">(5dc6a37)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121123/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>