<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119222/">https://git.reviewboard.kde.org/r/119222/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 13th, 2014, 11:36 a.m. CET, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119222/diff/6-7/?file=325067#file325067line3" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.h</a>
<span style="font-weight: normal;">
(Diff revisions 6 - 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"><span class="hl"> *</span> Copyright 2014 Adam Pigg <adam@piggz.co.uk></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> Copyright 2014 Adam Pigg <adam@piggz.co.uk></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With app due respect:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Copyright (C) 2014 Adam Pigg <a href="mailto:adam@piggz.co.uk" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">adam@piggz.co.uk</a></p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Misunderstanding, I said emails shall have < > brackets but reviewboard removed them :)</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 13th, 2014, 11:36 a.m. CET, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119222/diff/6-7/?file=325068#file325068line43" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 6 - 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRectF BoundedTextItem::boundingRect() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">painter</span><span class="o">-></span><span class="n">drawRect</span><span class="p">(</span><span class="n">boundingRect</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">painter</span><span class="o">-></span><span class="n">setBrush</span><span class="p">(</span><span class="n">o</span><span class="o">-></span><span class="n">palette</span><span class="p">.</span><span class="n">background</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why QPalette::Background? It's the same as QPalette::Windowm, i.e. gray. I guess we want to use Base...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related to DEFECT10.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moreover use it only when !m_backgroundColor.isValid().
When m_backgroundColor.isValid() use m_backgroundColor (as before).</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is not addressed (?) "Why QPalette::Background? It's the same as QPalette::Window, i.e. gray. I guess we want to use Base..."</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On November 14th, 2014, 10:07 p.m. CET, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2014, 10:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336825">336825</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:
Insert label
Double click to enter inline-edit mode
-Label text is selected and can be overwritten
Click away from item to exit edit mode
-Item text is updated with editor text</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Inserted label on new report and checked usage</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loaded existing report and ensured labels are editiable</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/items/label/BoundedTextItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/items/label/BoundedTextItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.h <span style="color: grey">(469de9d3626c58e55cc9ad4a2b4e7b61af7a7c7f)</span></li>
<li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(af21e56dd6fbc22e80c72eae9c5b166369f3c904)</span></li>
<li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(da2d4f5e8c8ca40713eb9936438355f7a5ee6c59)</span></li>
<li>libs/koreport/renderer/KoReportPrintRenderer.cpp <span style="color: grey">(08428520a1e8f8d319069ade7dd4df96dfa2edb3)</span></li>
<li>libs/koreport/renderer/KoReportScreenRenderer.cpp <span style="color: grey">(d19835b05a2f22c7db02f06af1fd0e149864dc2d)</span></li>
<li>libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp <span style="color: grey">(95aa265f874a77841c7b76820ef7bbcdbe89b3e9)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(48a667032a3a8049b69792c16d3cfc1727636fe7)</span></li>
<li>libs/koreport/wrtembed/reportscene.cpp <span style="color: grey">(2e9c54d29c135c041db75d2a843ea5bd8318e1c1)</span></li>
<li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(5762247fc783d77ccd141d46c601e669b942e4b8)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(54baaa9f84879e7bba1db1b7a8da2cec7722c919)</span></li>
<li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(7857466c4d7aa82a4be97d546cc77dc5333bd3c3)</span></li>
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(d8aea281ad0536e1423210014f09f616ee09f9af)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119222/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>