<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120934/">https://git.reviewboard.kde.org/r/120934/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, I'm sure I haven't thought through the entire problem but one thing stood out: with KF5's deprecation of kdialog, should we really add code that uses it?</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On November 1st, 2014, 3:28 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Arjen Hiemstra, Dan Leinir Turthra Jensen, and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2014, 3:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When testing Calligra Gemini with the Calligra test document set, I was wondering why "CalligraGemini" suddenly was inside the filenames displayed in the title. Reason is that the window title composing is custom made, using "%1" and "%2", strings which can be also found in the filenames of the test document set, as they are created from encoded origin urls.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And the code of Calligra Gemini is the same as in Krita Gemini and Krita Sketch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Attached patch proposes to just create the window title by falling back to the code KMainWindow also uses:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/kmainwindow_8cpp_source.html#l00552</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is one issue though, which I need input for. I suspected this line actually will be called if the current document is modified:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> connect(DocumentManager<span style="color: #666666">::</span>instance(), SIGNAL(documentChanged()), SLOT(resetWindowTitle()));
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But seems that the signal <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">documentChanged()</code> is only about that there was a switch which document is loaded.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So even after this patch the window title will never show the "[modified]" flag, which is different from how Desktop Krita behaves.
Intended (so the respective lines could be removed from this patch), or a bug?
If not intended, how and where should the modified signal be registered to and unregistered from?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/gemini/MainWindow.cpp <span style="color: grey">(d74c12c)</span></li>
<li>krita/sketch/MainWindow.cpp <span style="color: grey">(98a6c02)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120934/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>