<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120890/">https://git.reviewboard.kde.org/r/120890/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The changes on the kopageapp part and flake looks sensible to me.</p></pre>
<br />
<p>- Thorsten Zachmann</p>
<br />
<p>On November 4th, 2014, 3:51 p.m. UTC, Dan Leinir Turthra Jensen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dan Leinir Turthra Jensen.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2014, 3:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The many changes in this patch are all the ones found in the Calligra Gemini branch. It includes the addition of the Qt Quick compinents created a while ago by Arjen and Shantanu, as well as a number of changes which improves the writing performance and experience in Words, especially when dealing with very large documents. It further extends the template system with support for variations.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It does not include the gemini subdirectory itself (and as such to compile this you would need to check out the branch itself, rather than apply this patch), the reason being the large amount of data found in this subdirectory took the patch from the current 233KiB to a nice, solid 55MiB. So, i thought this would be more useful.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Compiles and shipped to users on Windows (through the Calligra Gemini packages)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Used every day for writing in a production environment (for producing my novel and recent short story)</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kopageapp/KoPADocumentModel.cpp <span style="color: grey">(22bd75a)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span style="color: grey">(f442b84)</span></li>
<li>CMakeLists.txt <span style="color: grey">(fa00fdd)</span></li>
<li>CalligraProducts.cmake <span style="color: grey">(c2ef8ac)</span></li>
<li>active/main.cpp <span style="color: grey">(7e4c888)</span></li>
<li>active/qml/Test.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/src/CASpreadsheetHandler.cpp <span style="color: grey">(e8cebff)</span></li>
<li>libs/flake/KoToolManager.h <span style="color: grey">(ac17dd0)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(5d4da91)</span></li>
<li>filters/words/docx/export/DocxFile.cpp <span style="color: grey">(d67e41f)</span></li>
<li>filters/words/msword-odf/wv2/src/utilities.cpp <span style="color: grey">(4be8c38)</span></li>
<li>krita/sketch/KisSketchView.cpp <span style="color: grey">(5cb9172)</span></li>
<li>krita/sketch/SketchDeclarativeView.cpp <span style="color: grey">(e352fc9)</span></li>
<li>libs/flake/KoCanvasController.h <span style="color: grey">(804a1e4)</span></li>
<li>libs/flake/KoCanvasController.cpp <span style="color: grey">(5190f62)</span></li>
<li>active/src/CATextDocumentModel.cpp <span style="color: grey">(4e72581)</span></li>
<li>active/src/MainWindow.cpp <span style="color: grey">(c378881)</span></li>
<li>cmake/modules/FindLibgit2.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindLibqgit2.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/templates/Wordprocessing/colorful.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/templates/Wordprocessing/fax.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/templates/Wordprocessing/professional.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/templates/Wordprocessing/ProfessionalLetter.desktop <span style="color: grey">(5f8b94f)</span></li>
<li>words/templates/Wordprocessing/a4.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/templates/Wordprocessing/ColorfulLetter.desktop <span style="color: grey">(ce38ab5)</span></li>
<li>words/templates/Wordprocessing/FaxA4.desktop <span style="color: grey">(2b43998)</span></li>
<li>words/templates/Wordprocessing/FaxLetter.desktop <span style="color: grey">(fc1c161)</span></li>
<li>words/templates/Wordprocessing/ProfessionalA4.desktop <span style="color: grey">(7c84f34)</span></li>
<li>stage/templates/odf/skyline_monotone_wide.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_morning.desktop <span style="color: grey">(ec4140d)</span></li>
<li>stage/templates/odf/skyline_morning.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_morning_wide.desktop <span style="color: grey">(d3337ae)</span></li>
<li>stage/templates/odf/skyline_morning_wide.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_night.desktop <span style="color: grey">(28e3a18)</span></li>
<li>stage/templates/odf/skyline_night.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_night_wide.desktop <span style="color: grey">(e188171)</span></li>
<li>stage/templates/odf/skyline_night_wide.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/flood_light.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/hisc-action-cohere-blue.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/hisc-action-cohere-gold.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/hisc-action-cohere-magenta.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/hisc-action-cohere-red.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/kde_events.desktop <span style="color: grey">(afa4534)</span></li>
<li>stage/templates/odf/kde_events.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/rounded_square.desktop <span style="color: grey">(85015a2)</span></li>
<li>stage/templates/odf/rounded_square.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/simple_waves.desktop <span style="color: grey">(dd2bd96)</span></li>
<li>stage/templates/odf/simple_waves.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_monotone.desktop <span style="color: grey">(0c9dd68)</span></li>
<li>stage/templates/odf/skyline_monotone.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/skyline_monotone_wide.desktop <span style="color: grey">(152c719)</span></li>
<li>stage/templates/odf/strange_far_hills.desktop <span style="color: grey">(1a17807)</span></li>
<li>stage/templates/odf/strange_far_hills.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(0d2d28f)</span></li>
<li>words/part/KWCanvasItem.cpp <span style="color: grey">(cfdae98)</span></li>
<li>words/part/KWGui.cpp <span style="color: grey">(65aedf7)</span></li>
<li>words/part/KWPageStyle.h <span style="color: grey">(a3bf58b)</span></li>
<li>words/part/KWView.h <span style="color: grey">(f21f8e3)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(1285d21)</span></li>
<li>words/part/commands/KWShapeCreateCommand.h <span style="color: grey">(eb268f8)</span></li>
<li>words/part/dockers/KWNavigationWidget.cpp <span style="color: grey">(1bb54e0)</span></li>
<li>words/part/dockers/KWStatisticsWidget.h <span style="color: grey">(eac4d44)</span></li>
<li>words/part/dockers/KWStatisticsWidget.cpp <span style="color: grey">(63d0384)</span></li>
<li>words/part/frames/KWCopyShape.cpp <span style="color: grey">(744f292)</span></li>
<li>words/part/pagetool/KWPageTool.cpp <span style="color: grey">(7935390)</span></li>
<li>words/templates/Wordprocessing/A4.desktop <span style="color: grey">(8a35eaf)</span></li>
<li>words/templates/Wordprocessing/CMakeLists.txt <span style="color: grey">(88b73fa)</span></li>
<li>words/templates/Wordprocessing/ColorfulA4.desktop <span style="color: grey">(04caf8e)</span></li>
<li>stage/templates/odf/cohere-magenta.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-magenta.otp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-magenta.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-red.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-red.otp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-red.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/curious_penguin.desktop <span style="color: grey">(429e7c9)</span></li>
<li>stage/templates/odf/curious_penguin.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/flood_light.desktop <span style="color: grey">(23adbb2)</span></li>
<li>stage/templates/odf/blue_orange_vector.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/burning_desire.desktop <span style="color: grey">(ac79022)</span></li>
<li>stage/templates/odf/burning_desire.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/business.desktop <span style="color: grey">(d552db3)</span></li>
<li>stage/templates/odf/business.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-blue.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-blue.otp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-blue.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-gold.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-gold.otp <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/templates/odf/cohere-gold.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQThumbnailItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQThumbnailItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CalligraQtQuickComponentsPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CalligraQtQuickComponentsPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrView.h <span style="color: grey">(b4bab24)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(1edd8e8)</span></li>
<li>stage/part/animations/KPrAnimTransitionFilter.cpp <span style="color: grey">(3347fe1)</span></li>
<li>stage/part/animations/KPrAnimateColor.cpp <span style="color: grey">(59a5e0e)</span></li>
<li>stage/part/animations/KPrAnimateTransform.cpp <span style="color: grey">(914047e)</span></li>
<li>stage/templates/common_desktop/emptyLandscapeWide.desktop <span style="color: grey">(c5f8f8a)</span></li>
<li>stage/templates/odf/CMakeLists.txt <span style="color: grey">(f7db7d0)</span></li>
<li>stage/templates/odf/blue_orange_vector.desktop <span style="color: grey">(31dae09)</span></li>
<li>qtquick/CQCanvasBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQCanvasController.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQCanvasController.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQCanvasControllerItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQCanvasControllerItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQImageProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQImageProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQLinkArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQLinkArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPluginLoaderProxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPluginLoaderProxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationCanvas.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationCanvas.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQPresentationView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQSpreadsheetCanvas.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQSpreadsheetCanvas.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQSpreadsheetListModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQSpreadsheetListModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentCanvas.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentCanvas.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentNotesModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextDocumentNotesModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextToCModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQTextToCModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/defaultTools/defaulttool/SelectionDecorator.h <span style="color: grey">(83e715e)</span></li>
<li>plugins/defaultTools/defaulttool/SelectionDecorator.cpp <span style="color: grey">(3e16cfa)</span></li>
<li>qtquick/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>qtquick/CQCanvasBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(4770dcc)</span></li>
<li>libs/main/gemini/ViewModeSwitchEvent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/odf/KoEncryptedStore.cpp <span style="color: grey">(53c75b6)</span></li>
<li>libs/widgets/KoZoomAction.h <span style="color: grey">(c5f69b0)</span></li>
<li>libs/main/KoTemplate.h <span style="color: grey">(f96099c)</span></li>
<li>libs/main/KoTemplate.cpp <span style="color: grey">(f1d3bd9)</span></li>
<li>libs/main/KoTemplateCreateDia.cpp <span style="color: grey">(72573cc)</span></li>
<li>libs/main/KoTemplateGroup.cpp <span style="color: grey">(ab35dd1)</span></li>
<li>libs/main/KoTemplateTree.cpp <span style="color: grey">(8f864b4)</span></li>
<li>libs/main/KoDocument.h <span style="color: grey">(c3936a9)</span></li>
<li>libs/main/KoDocumentSectionDelegate.cpp <span style="color: grey">(81c53c0)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(8db43f8)</span></li>
<li>libs/main/KoPart.cpp <span style="color: grey">(04b8d25)</span></li>
<li>libs/main/KoApplication.cpp <span style="color: grey">(b20c0e9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120890/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>