<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119222/">https://git.reviewboard.kde.org/r/119222/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Partial review, not yet clicked through it...</p></pre>
 <br />







<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/3-4/?file=290212#file290212line3" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.h</a>
    <span style="font-weight: normal;">

     (Diff revisions 3 - 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright 2014  Adam Pigg <<span class="hl">email</span>></span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright 2014  Adam Pigg <<span class="hl">adam@piggz.co.uk</span>></span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Licenses still shall be fixed, you can just use other file's license headers. Here you use the GPL (by mistake?)... :)</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/3-4/?file=290212#file290212line23" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.h</a>
    <span style="font-weight: normal;">

     (Diff revisions 3 - 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef BOUNDEDTEXTITEM_H</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef BOUNDEDTEXTITEM_H</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use KOREPORT prefix to avoid issues when KoReport goes general-purpose</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/3-4/?file=290212#file290212line26" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.h</a>
    <span style="font-weight: normal;">

     (Diff revisions 3 - 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <qgraphicsitem.h></span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <qgraphicsitem.h></span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would <QGraphicsTextItem> be sufficient?</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/3-4/?file=290213#file290213line28" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/BoundedTextItem.cpp</a>
    <span style="font-weight: normal;">

     (Diff revisions 3 - 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">m_backgroundColor</span> <span class="o">=</span> <span class="n">Qt</span><span class="o">::</span><span class="n">white</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hardcoded... not needed to initialize at all because in paint() we have QStyleOptionGraphicsItem::palette. QPalette::Base brush can be used or so when !m_backgroundColor.isValid().</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/5-6/?file=324861#file324861line61" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/LabelEditButton.cpp</a>
    <span style="font-weight: normal;">

     (Diff revisions 5 - 6)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">painter</span><span class="o">-></span><span class="n"><span class="hl">fillRect</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QGraphicsRectItem</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">rect</span></span><span class="p"><span class="hl">(),</span></span><span class="hl"> </span><span class="n">QColor</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">lightGray</span><span class="p">));</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">painter</span><span class="o">-></span><span class="n"><span class="hl">setBrush</span></span><span class="p"><span class="hl">(</span></span><span class="n">QColor</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">lightGray</span><span class="p">));</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Instead of gray:
According to the docs, painter's pen is initialized to the QPalette::Text brush from the paint device's palette.
So you can use it, set alpha to 128 or so.</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/119222/diff/5-6/?file=324861#file324861line63" style="color: black; font-weight: bold; text-decoration: underline;">libs/koreport/items/label/LabelEditButton.cpp</a>
    <span style="font-weight: normal;">

     (Diff revisions 5 - 6)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">painter</span><span class="o">-></span><span class="n">drawPixmap</span><span class="p">(</span><span class="n">rect</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span class="o">+</span> <span class="p">((</span><span class="n">rect</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span class="o">-</span> <span class="mi">18</span><span class="p">)</span> <span class="o">/</span> <span class="mi">2</span><span class="p">),</span> <span class="n">rect</span><span class="p">().</span><span class="n">y</span><span class="p">()</span> <span class="o">+</span> <span class="p">((</span><span class="n">rect</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span class="o">-</span> <span class="mi">18</span><span class="p">)</span> <span class="o">/</span> <span class="mi">2</span><span class="p">),</span> <span class="n">QPixmap</span><span class="p">(</span><span class="n">pencil_xpm</span><span class="p">));</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's use QPixmap::size() instead of hardcoding</p></pre>
 </div>
</div>
<br />



<p>- JarosÅ‚aw Staniek</p>


<br />
<p>On November 3rd, 2014, 8:49 p.m. CET, Adam Pigg wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Calligra and JarosÅ‚aw Staniek.</div>
<div>By Adam Pigg.</div>


<p style="color: grey;"><i>Updated Nov. 3, 2014, 8:49 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=336825">336825</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:
Insert label
Double click to enter inline-edit mode
-Label text is selected and can be overwritten
Click away from item to exit edit mode
-Item text is updated with editor text</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Inserted label on new report and checked usage</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Loaded existing report and ensured labels are editiable</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/koreport/items/label/BoundedTextItem.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/koreport/CMakeLists.txt <span style="color: grey">(d8aea281ad0536e1423210014f09f616ee09f9af)</span></li>

 <li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(ac628616b52b4769232a55af07a51bea9fd80c0a)</span></li>

 <li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(f386f9b99c9584f1122fbee542fb708bf5121f16)</span></li>

 <li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(b129299e160c65d1d9f6ed691800e1d6095a5364)</span></li>

 <li>libs/koreport/wrtembed/reportscene.cpp <span style="color: grey">(2e9c54d29c135c041db75d2a843ea5bd8318e1c1)</span></li>

 <li>libs/koreport/items/label/BoundedTextItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/koreport/items/label/KoReportDesignerItemLabel.h <span style="color: grey">(5aa3b48563216db6dc8bd1f8f4c43a7c7bf7dce8)</span></li>

 <li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(8bebbd218fb7f432731af646703cd5e31c3b5245)</span></li>

 <li>libs/koreport/items/label/LabelEditButton.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/koreport/items/label/LabelEditButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(7af69c4840bd910a7a8ee158d2c89d5f9096ed2a)</span></li>

 <li>libs/koreport/renderer/KoReportPrintRenderer.cpp <span style="color: grey">(08428520a1e8f8d319069ade7dd4df96dfa2edb3)</span></li>

 <li>libs/koreport/renderer/KoReportScreenRenderer.cpp <span style="color: grey">(d19835b05a2f22c7db02f06af1fd0e149864dc2d)</span></li>

 <li>libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp <span style="color: grey">(95aa265f874a77841c7b76820ef7bbcdbe89b3e9)</span></li>

 <li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(2e1bd502c508ee429205bb7528518de16cc5444b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119222/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>