<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120898/">https://git.reviewboard.kde.org/r/120898/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2014, 8:11 p.m. CET, <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What does it look like with a scroll bar? Where are the button actions gone from the top?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://wstaw.org/m/2014/10/30/plasma-desktopxB1834.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These are kept in the context menu. There will be a small drop-down 'v' icon on the right hand of the current item. It's like Labels tree in browser-based gmail client.</p></pre>
<br />
<p>- Jarosław</p>
<br />
<p>On October 30th, 2014, 3:54 p.m. CET, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2014, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Make side panes lighter by removing frames</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">- works in all styles except oxygen
- define a general purpose Close button, use it everywhere (in the docks, pages, message widgets)
- by the way, remove saving position of panes, this fixes right-to-left support</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Update: 3rd patch that actually complements the refresh. Feel free to wait for it. The screenshots show Kexi with all the 3 patches applied.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">runs nicely with all the styles as before</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexiutils/CMakeLists.txt <span style="color: grey">(f04ff0a5c37f6d6ba2de19b4a4c9e78a202d443d)</span></li>
<li>kexi/kexiutils/KexiAssistantPage.cpp <span style="color: grey">(6456e8780da5807d5c1b7db150ee1bd02c1b555b)</span></li>
<li>kexi/kexiutils/KexiCloseButton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/kexiutils/KexiCloseButton.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/kexiutils/kmessagewidget.cpp <span style="color: grey">(799730f6442018431be8f1adb226c9ee2cca28b9)</span></li>
<li>kexi/kexiutils/styleproxy.h <span style="color: grey">(936232883432cc526b85cb987379c54ec9334d2a)</span></li>
<li>kexi/kexiutils/styleproxy.cpp <span style="color: grey">(9381bbc9800af3eb28bb7b5774fe32371bc7b07c)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(3e0d0fccf10dfea01e3707bca96d84c1e7879dc0)</span></li>
<li>kexi/main/KexiMainWindow_p.h <span style="color: grey">(fc5b695ab114426da066afa7007ff6a841b27a4f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120898/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/29/9b2bae33-bde0-492b-8455-7523265f3729__1.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/30/b9e28598-b52b-4f7b-96fa-30c254016769__1.png">Kexi with Oxygen style - maintains frame because the style defines it in a more hardcoded way</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/10/30/fabd15f3-00eb-4b83-bd28-b26c2fcce5cc__2.png">Kexi in Windows style: splitters are visible</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>