<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120875/">https://git.reviewboard.kde.org/r/120875/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 28th, 2014, 11:24 p.m. UTC, <b>Wolthera van Hövell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested it and it works well, except the values would need to be 4x more sensitive to work on my wacom graphire 3. Might be different per device.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested mapping the physical speed to the sensor value with a log scale and the result feel a lot more natural. It's a subjective scale, differences in high speed are a lot less important than differences in low speed.
I can follow up with a new version of the patch, but that means even more wild guessed constants, that's nowhere near sane programming to my taste :D
There's an implementation of that mapping in libmypaint : https://github.com/mypaint/libmypaint/blob/0a6ad9de9debb9786bcc23cef19446410ac042a5/mypaint-brush.c#L396</p></pre>
<br />
<p>- Damien</p>
<br />
<p>On October 28th, 2014, 11:10 p.m. UTC, Damien de Lemeny wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Damien de Lemeny.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2014, 11:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch intends to fix the broken speed sensor of the brush tool.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's based on a patch I got from Wolthera, which was discarded/unfinished because the output of the sensor remained "blobby".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I added a smoothing formula to the speed output :</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">output_speed = current_speed * 0.1 + last_speed * 0.9</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The used numeric values are either eyeballed or wild guessed from usage. There's certainly room for improvements on this patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested the ux of a speed bound preset before and after the patch and compared to the behaviour of a similar test brush in Mypaint.
Results are noticeable improvements when painting strokes at different speeds with the fix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's also been tested by Wolthera</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/brushengine/kis_paint_information.cc <span style="color: grey">(264ad43)</span></li>
<li>krita/image/kis_distance_information.h <span style="color: grey">(70fa25e)</span></li>
<li>krita/image/kis_distance_information.cpp <span style="color: grey">(1c1c847)</span></li>
<li>krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.cc <span style="color: grey">(6b10e2b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120875/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>