<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120653/">https://git.reviewboard.kde.org/r/120653/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On October 19th, 2014, 3:53 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2014, 3:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wigdets (and even more QWidget-based ones) make most sense if all collected in kowidgets, and not only some.
kowidgets already contains many widgets (which know about classes from kotext and flake).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So I propose to move KoRuler, KoRulerController and KoFontComboBox from komain to kowidgets. That way QML-based apps that use komain do not need to care about these classes. And koreport no longer needs to link to komain, but can "just" go with kowidgets and its deps.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine here.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoRulerController.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoRulerController_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoRuler_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoRuler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoRulerController.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(3f648b7)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(2affede)</span></li>
<li>libs/main/KoFontComboBox.h <span style="color: grey">(47d1550)</span></li>
<li>libs/main/KoRuler.h <span style="color: grey">(2c4875d)</span></li>
<li>libs/main/KoRuler.cpp <span style="color: grey">(6f49a1e)</span></li>
<li>libs/main/KoRulerController.h <span style="color: grey">(5543da7)</span></li>
<li>libs/main/KoRulerController.cpp <span style="color: grey">(9b433f4)</span></li>
<li>libs/main/KoRulerController_p.h <span style="color: grey">(1779972)</span></li>
<li>libs/main/KoRuler_p.h <span style="color: grey">(7c63e0a)</span></li>
<li>libs/widgets/CMakeLists.txt <span style="color: grey">(2268054)</span></li>
<li>libs/widgets/KoFontComboBox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoRuler.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>