<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119224/">https://git.reviewboard.kde.org/r/119224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 11th, 2014, 12:58 p.m. UTC, <b>Dmitry Kazakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, Sven!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is effectively an equivalent of the following patch:
http://paste.kde.org/poktyzric</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course, except that the variable should not be static, but put into d->currentDistanceInfo. Your patch just creates one more timer, which is excessive, since we already have a timer in KisFreehandToolHelper and which is already used for all speed calculations.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch doesn't solve the real cause of the speed sensor being broken. The speed doesn't work because we should fetch the time data from the XInput/Wintab event directly, instead of running a timer in parallel. The trick is that on both windows and linux the packets are coming in chunks and Qt's event loop processes the whole chunk of packets in one go. So measuring time with a timer gives the same time for the whole chunk, which is not what we need.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm ok with introducing a limitation you proposed (timeDiff > 5 msec), but the second timer is not needed. Everything can be implemented inside KisPaintInformation.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, what's the status now? Should we discard this patch and do a new one?</p></pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On July 11th, 2014, 3:30 a.m. UTC, Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated July 11, 2014, 3:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325423">325423</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The speed sensor is currently broken. The problem is that the speed is calculated with the distance and time difference each dab and the previous one. When the space between the dabs becomes to small the calculation breakes and falls back to a constant value.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch fixes the problem by calculating the speed of every event and then interpolating the speed between them. It also makes sure that there a minimum time difference between the measurements.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested by painting in Krita and appears to work. Needs further testing to see if it gives the expected results.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/brushengine/kis_paint_information.h <span style="color: grey">(9b3be8f)</span></li>
<li>krita/image/brushengine/kis_paint_information.cc <span style="color: grey">(952f51f)</span></li>
<li>krita/ui/tool/kis_painting_information_builder.h <span style="color: grey">(993c25b)</span></li>
<li>krita/ui/tool/kis_painting_information_builder.cpp <span style="color: grey">(6e3d19a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119224/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>