<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109994/">https://git.reviewboard.kde.org/r/109994/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 6th, 2014, 2:13 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi. Discussion on this review request has stopped more than a year ago. I hope it could be started again soon by perhaps an updated version of the patch? Without that though we better close this RR, given there is no activity. Will close end of July.</p></pre>
</blockquote>
<p>On July 7th, 2014, 2:42 a.m. UTC, <b>Yue Liu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">formula rendering through qmmlwidget is ugly, there is a libmathview project providing TeX quality rendering with Opentype MATH table support, which is a gtkmathview fork, I made a qt5 backend for it, after we ported to qt5 we can use it in calligra.
https://github.com/khaledhosny/libmathview</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, is the consensus that this is the way to go and should we close this RR?</p></pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On April 19th, 2013, 2:25 p.m. UTC, Gopalakrishna Bhat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Gopalakrishna Bhat.</div>
<p style="color: grey;"><i>Updated April 19, 2013, 2:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This new implementation for formulashape uses and improves on qtmmlwidgets that was part of Qt Solutions. The code can be found in plugins-formulashape2g-gopalK branch.
Currently implemented features are
1) Loading of formulas in document.
2) Insert of MathML formulas generated from some other tools(viz FireMath plugin for Firefox)
3) Editing of existing formulas.
Features that were there in old version of formulashape but missing now
1) Insert of Elements, Symbols (in a very much unusable state)
2) Edit formulas with LaTeX syntax (Will be done in coming days)
I will remove the extra whitespace that exists in the uploaded diff before merging :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/staging/CMakeLists.txt <span style="color: grey">(754362f)</span></li>
<li>plugins/staging/formulashape-2g/AlterFormulaCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/AlterFormulaCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/ChangeFormulaCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/ChangeFormulaCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaCursor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaCursor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaPart.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaPart.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShape.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShape.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapeFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapeFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaShapePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaTool.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaTool.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaToolFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/FormulaToolFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/formula_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/formulashape2g.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LGPL_EXCEPTION.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.GPL3 <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.LGPL <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/QtMmlDocument <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/QtMmlWidget <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/README.TXT <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109994/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/formulaShape.png">Snapshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>