<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120469/">https://git.reviewboard.kde.org/r/120469/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm sure it's fine... But sketch/gemini cannot work without opengl and glew anyway.</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On October 3rd, 2014, 1:05 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Arjen Hiemstra, Dan Leinir Turthra Jensen, and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2014, 1:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If Glew lib headers are not found, compilation fails with</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">CMake Error<span style="color: #666666">:</span> The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files<span style="color: #666666">:</span>
GLEW_LIBRARY (ADVANCED)
linked by target <span style="color: #BA2121">"kritaui"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>ui
linked by target <span style="color: #BA2121">"kritasketch"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>sketch
linked by target <span style="color: #BA2121">"kritasketch"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>sketch
linked by target <span style="color: #BA2121">"kritasketchlib"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>sketch
linked by target <span style="color: #BA2121">"kritasketchplugin"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>sketch
linked by target <span style="color: #BA2121">"kritagemini"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>gemini
linked by target <span style="color: #BA2121">"kritagemini"</span> in directory [...]<span style="color: #666666">/</span>calligra.master<span style="color: #666666">/</span>krita<span style="color: #666666">/</span>gemini
<span style="color: #666666">--</span> Configuring incomplete, errors occurred<span style="color: #666666">!</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Attached patch fixes that by only using GLEW_LIBRARY to set GLEW_LIBRARIES if found.
It also removes a few duplicated listing of GLEW_LIBRARIES as libs to link to. I assume that duplication was not done on purpose, at least it links for me also this way.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/CMakeLists.txt <span style="color: grey">(18ba261)</span></li>
<li>krita/gemini/CMakeLists.txt <span style="color: grey">(9f1f64b)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(1aa4f64)</span></li>
<li>cmake/modules/FindGLEW.cmake <span style="color: grey">(2d76562)</span></li>
<li>krita/sketch/CMakeLists.txt <span style="color: grey">(46e0ba4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120469/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>