<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120545/">https://git.reviewboard.kde.org/r/120545/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Adam Pigg</p>
<br />
<p>On October 9th, 2014, 11:14 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2014, 11:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kexi had a copy of pg_type.h from somewhere. This is always dangerous.
To find proper pg_type.h we need to override system FindPostgreSQL.cmake
(kdelibs' one is outdated, and even the one from cmake 3 isn't sufficient).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So a copy from current libPredicate is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(Kexi 3 will not use this workaround, but depend on what Predicate finds)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Master builds and runs</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/pqxx/pg_type.h <span style="color: grey">(e36435690a3812b751d8fc554f041af729eac0d8)</span></li>
<li>kexi/migration/pqxx/pqxxmigrate.cpp <span style="color: grey">(47c036a2506ad5a3841756a998d60b242e316dd7)</span></li>
<li>kexi/kexidb/drivers/pqxx/CMakeLists.txt <span style="color: grey">(d8e92e5962bcb2bae702d5c143ec68972622eb4d)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxcursor.h <span style="color: grey">(7af911ef2d68801ae6eb6e8371f3c9a3645fab1a)</span></li>
<li>kexi/migration/pqxx/CMakeLists.txt <span style="color: grey">(6fe14a0d1fe05384517ce43aa80c8f41f4e4487b)</span></li>
<li>cmake/modules/FindCalligraPostgreSQL.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/CMakeLists.txt <span style="color: grey">(55d5e43d01b960cabc41a098bbdf8e53964c91e3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120545/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>