<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120505/">https://git.reviewboard.kde.org/r/120505/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 10th, 2014, 8:13 p.m. UTC, <b>Sven Langkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KisPaintingAssistantsDecoration is a KisCanvasDecoration which already has setVisible and toggleVisible. It's not needed to do the setAssistantVisible, I think.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes indeed, it does.
However, if we use that, it won't allow me to paint the previews and the base-assistant seperately(as it will just prevent KisPaintingAssistantDecoration from painting anything at all), unless I start modifying kis_canvas_widget_base, and I wanted to keep this isolated.
Unless you think it's better to seperate this.</p></pre>
<br />
<p>- Wolthera</p>
<br />
<p>On October 10th, 2014, 7:06 p.m. UTC, Wolthera van Hövell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.</div>
<div>By Wolthera van Hövell.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2014, 7:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a little eye icon underneath the deletion icon which can be used to activate/deactivate snapping and in the case of the perspective assistant, add a preview for where the snapping will happen/head to.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This last bit of code may be refactored a little more, if I want to allow to option to see this preview without having the basic assistant visible. This would allow these previews to make sense on normal assistants as well.
(Right now, the 'hide assistants' button in view just makes the whole widget invisible).[done]
Preview will be important if we're gonna have parallel rulers and the like.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also fixed a minor bug where the canvas wasn't passed to the drawAssistant function in the painting assistant by the PaintingAssistantDecorations class, because whoever wrote the caching system had added a boolean for it in the arguments in a rather random place. Both caching and me accessing the canvas for cursor conversion work now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Update: Added a whole framework so that the previews and main assistant can be toggled seperately. I also implemented preview for Ellipse, Ruler and Spline based on intersection with the bounding box. This won't help much when there's only one ruler on the canvas, but with multiple insersecting rulers this gives tremendous feedback.
I replaced the 'show painting assistants' action internally with the option to toggle the assistants themselves, instead of turning of visiblity for the whole widget.
I also added a new action 'Show Assistant previews'. This allows the user to disable all previews globally. Because I added this action, the kritarc file is set to version 53 from 52.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lots, I can't find any crashes or bugs here.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/krita.rc <span style="color: grey">(50faa31)</span></li>
<li>krita/plugins/assistants/RulerAssistant/EllipseAssistant.h <span style="color: grey">(e36bd9d)</span></li>
<li>krita/plugins/assistants/RulerAssistant/EllipseAssistant.cc <span style="color: grey">(ec6ee06)</span></li>
<li>krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.h <span style="color: grey">(c4fd3b2)</span></li>
<li>krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.cc <span style="color: grey">(e3ec525)</span></li>
<li>krita/plugins/assistants/RulerAssistant/RulerAssistant.h <span style="color: grey">(388b18a)</span></li>
<li>krita/plugins/assistants/RulerAssistant/RulerAssistant.cc <span style="color: grey">(dd173c0)</span></li>
<li>krita/plugins/assistants/RulerAssistant/SplineAssistant.h <span style="color: grey">(92ccb49)</span></li>
<li>krita/ui/kis_painting_assistants_decoration.cpp <span style="color: grey">(dd65ec0)</span></li>
<li>krita/plugins/assistants/RulerAssistant/SplineAssistant.cc <span style="color: grey">(8391f65)</span></li>
<li>krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h <span style="color: grey">(11e92f3)</span></li>
<li>krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc <span style="color: grey">(bbfe5cd)</span></li>
<li>krita/ui/canvas/kis_canvas_decoration.cc <span style="color: grey">(9179d3f)</span></li>
<li>krita/ui/canvas/kis_canvas_widget_base.cpp <span style="color: grey">(02f0ab5)</span></li>
<li>krita/ui/kis_painting_assistant.h <span style="color: grey">(6f315e8)</span></li>
<li>krita/ui/kis_painting_assistant.cc <span style="color: grey">(81c6069)</span></li>
<li>krita/ui/kis_painting_assistants_decoration.h <span style="color: grey">(a2c1263)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120505/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>