<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120412/">https://git.reviewboard.kde.org/r/120412/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I checked and it doesn't hit problems with my mvc branch and the new code looks much more sensible. I didn't do load/save tests with a range of apps, though.</p></pre>
<br />
<p>- Boudewijn Rempt</p>
<br />
<p>On September 28th, 2014, 10:31 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2014, 10:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As promised during the Calligra sprint I am currently working on moving UI-interaction out of KoStore classes, both to support automatic processing using KoStore where no UI is happening but also and mainly for supporting non-QWidget environments. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And I was confused by the wired setup in the KoStore (sub)classes:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Initialisation of the d-object is done directly, not via the constructor parameters as usual<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> wired virtual init method: not only should virtual methods should not be called from constructors, also is there no real need to have this method virtual here, as the base implementation is explicitely called anyway and never expected to be called by someone else. and it also duplicates a lot of the initialisation done by KoStorePrivate constructor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Attached patch simplifies the concepts a little, and will make future PRs for deUIfication of KoStore easier.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also removes strange initialisation of members in KoEncryptedStore constructor with pattern "member(Type())", so creating a temp object and then passing it to the member's copy constructor, which seems not intended.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/tiles3/tests/tiles_test_utils.h <span style="color: grey">(87f7c29)</span></li>
<li>libs/odf/KoDirectoryStore.h <span style="color: grey">(7127e35)</span></li>
<li>libs/odf/KoDirectoryStore.cpp <span style="color: grey">(01decfc)</span></li>
<li>libs/odf/KoEncryptedStore.h <span style="color: grey">(2c453f5)</span></li>
<li>libs/odf/KoEncryptedStore.cpp <span style="color: grey">(a9b14df)</span></li>
<li>libs/odf/KoStore.h <span style="color: grey">(e269ad8)</span></li>
<li>libs/odf/KoStore.cpp <span style="color: grey">(4479deb)</span></li>
<li>libs/odf/KoStore_p.h <span style="color: grey">(aff15e4)</span></li>
<li>libs/odf/KoTarStore.h <span style="color: grey">(a5437ac)</span></li>
<li>libs/odf/KoTarStore.cpp <span style="color: grey">(772bcb9)</span></li>
<li>libs/odf/KoZipStore.h <span style="color: grey">(eff0fb0)</span></li>
<li>libs/odf/KoZipStore.cpp <span style="color: grey">(88afd16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120412/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>