<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120326/">https://git.reviewboard.kde.org/r/120326/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 11:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">const char *x[]</code> is still a variable, being an array of non-const pointers to const chars, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">x[2] = anotherconststring;</code> is still possible.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">const char * const x[]</code> is a const itself, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">x[2] = anotherconststring;</code> no longer possible. And is one indirection less when accessing the data, because x is now the symbol of the actual data and not of the variable keeping the address of the actual data.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexidb/drivers/mysql/mysqldriver.h <span style="color: grey">(9eb1813)</span></li>
<li>kexi/kexidb/drivers/mysql/mysqlkeywords.cpp <span style="color: grey">(f1dbde5)</span></li>
<li>kexi/kexidb/drivers/oracle/oracle_keywords.sh <span style="color: grey">(49a627f)</span></li>
<li>kexi/kexidb/drivers/oracle/oracledriver.h <span style="color: grey">(11ee497)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclekeywords.cpp <span style="color: grey">(2163690)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.h <span style="color: grey">(b8b513f)</span></li>
<li>kexi/kexidb/drivers/pqxx/pqxxkeywords.cpp <span style="color: grey">(4bac74a)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasedriver.h <span style="color: grey">(196c08b)</span></li>
<li>kexi/kexidb/drivers/sybase/sybasekeywords.cpp <span style="color: grey">(0071da3)</span></li>
<li>kexi/kexidb/drivers/xbase/xbasedriver.h <span style="color: grey">(1281cd0)</span></li>
<li>kexi/kexidb/drivers/xbase/xbasekeywords.cpp <span style="color: grey">(7c1c42b)</span></li>
<li>kexi/tools/sql_keywords/sql_keywords.sh <span style="color: grey">(be4eeed)</span></li>
<li>libs/db/driver.h <span style="color: grey">(f041c20)</span></li>
<li>libs/db/driver.cpp <span style="color: grey">(d6b4610)</span></li>
<li>libs/db/driver_p.h <span style="color: grey">(7f8ccea)</span></li>
<li>libs/db/drivers/sqlite/sqlitedriver.h <span style="color: grey">(92c011d)</span></li>
<li>libs/db/drivers/sqlite/sqlitekeywords.cpp <span style="color: grey">(04ca0f0)</span></li>
<li>libs/db/keywords.cpp <span style="color: grey">(03c44d1)</span></li>
<li>libs/db/utils.h <span style="color: grey">(01e27cf)</span></li>
<li>libs/db/utils.cpp <span style="color: grey">(8414217)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120326/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>