<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119183/">https://git.reviewboard.kde.org/r/119183/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.</div>
<div>By Wolthera van Hövell.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2014, 4:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=313787">https://bugs.kde.org/show_bug.cgi?id=313787</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have been working on this https://bugs.kde.org/show_bug.cgi?id=313787.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a color sliders docker to Krita.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The intention is to eventually get to a docker that can can be modified through the preferences, so one could have only saturation sliders, or two saturations sliders and a value slider.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This docker is only intended for derived models, where the specific colour selector is for actual colour spaces.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A lot, no user testing, there's still a handful of open bugs.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
We have 12 sliders, for each of the HSX colour models.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
It compiles, and it doesn't crash.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> ~~Kocolorsliders wasn't intended for HSX, so we'll need to write a new widget for HSX.~~[done]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> ~~For now, all 12 sliders show up using kocolor sliders. I have managed to prevent it from zealously updating everything else, so it doesn't break other things.~~ [Thanks to the fix by dmitry on the specific colour selector, this has been fixed]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> ~~The number-input is broken. Half of the time~~ [fixed, I made it so that it will only change after loosing focus]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> ~~So is the slider input itself, I suspect this is rounding errors again, and will have to adjust the self-update, like I did for the colour palette.~~ We need to increase the precision of all the algoritms.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> ~~Config still needs to be put in.[done, however, after the config is changed, it doesn't re-update the docker again, on restart the update takes place.]~~[done]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> ~~There's still licenses missing~~[done]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> ~~The code is a bloody mess.~<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> ~~There's a bug in the hsy and hsi code I wrote, but there's also bugs in the qt hsv and hsl code(gray in particular is strange) I'll chase these down with increasing the precision.~~ Fixed.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> There's some awkwardness between the different colour models updating eachother, leading to slider-dancing. Hopefull this'll be fixed with precision increase.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> The sliders don't update properly on LUT changes. This also happens in the specific colour selector.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I want to do these last two in a seperate patch.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Made the H and S sliders work when the colour is black, as requested by Sven.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> Aligned the labels to the right..<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* Couldn't set the labels to align perfectly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/dockers/CMakeLists.txt <span style="color: grey">(f94eb44)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.cpp <span style="color: grey">(f171c2e)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui <span style="color: grey">(dbe9070)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_dock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_dock.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_input.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_hsv_slider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/kis_hsv_slider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/colorslider/krita_colorslider.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/pigment/KoColorConversions.cpp <span style="color: grey">(fc7954b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119183/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>