<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120011/">https://git.reviewboard.kde.org/r/120011/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Sven Langkamp and Thorsten Zachmann.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Much more expected than exiting edit-mode and going to the first or last page.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This required to pass QEvent::ShortcutOverride event to tools, via viewmodes.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The name shortcutOverrideEvent() is made up, QWidget doesn't have a specific<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
virtual method for this and requires reimplementing event(QEvent*) instead.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
But I find that shortcutOverrideEvent is much nicer to have :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This new virtual method could be used to refine the earlier commits<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
which implemented some blind rule ("keys without modifiers or with shift"),<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
while the right way to do it is to accept the specific shortcuts handled<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
by the current tool (which can also include shortcuts with CTRL or even ALT,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
and maybe does NOT include some shortcuts without modifiers, like PageUp or Esc...).<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
CCMAIL: sven.langkamp@gmail.com</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ctrl+Home/Ctrl+End in stage. Didn't test the other apps, but they should be unaffected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoToolBase.h <span style="color: grey">(e84bd389a32af6cecb8a37be94010c0bebf70f4f)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(5dfd57ebfdc0f10eb1ce0e8a21e870ac69f79bb9)</span></li>
<li>libs/kopageapp/KoPACanvasItem.h <span style="color: grey">(eb6b929bc24da248ddd5a62892030c2012957a32)</span></li>
<li>libs/kopageapp/KoPACanvasItem.cpp <span style="color: grey">(17790be4b1a64738a106b30eb7753278a8ae44d3)</span></li>
<li>libs/kopageapp/KoPAViewMode.h <span style="color: grey">(043b27c7273230d4dea368c2e2bc7a7dead2983f)</span></li>
<li>libs/kopageapp/KoPAViewModeNormal.h <span style="color: grey">(86b1e0422b7dfead2b47cee8858632a36fdc5d46)</span></li>
<li>libs/kopageapp/KoPAViewModeNormal.cpp <span style="color: grey">(faba4dd9e6eda1ad7a4bc171b6f8e5d6ac0e1055)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(340929215def4c254ec4c62bd7ffc140adf02ebf)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(2bf8787816c100dbd7acde8ac730e91676a3ac41)</span></li>
<li>stage/part/KPrViewModeNotes.h <span style="color: grey">(f1f008063c3c3f6e73349817161f9aa3f5cdc170)</span></li>
<li>stage/part/KPrViewModeNotes.cpp <span style="color: grey">(4cca0212e09c1b96a1bf864e8116eb96b35bf4f6)</span></li>
<li>stage/part/KPrViewModePresentation.h <span style="color: grey">(99d14dad95de9ac62b5cdb98c42c4040d0ee0488)</span></li>
<li>stage/part/KPrViewModePresentation.cpp <span style="color: grey">(c72c59431a78c17574b1137881a2076fc17b2e24)</span></li>
<li>stage/part/KPrViewModePreviewPageEffect.h <span style="color: grey">(463502e23e6e02bb7a7f3748d9678aa3e9db4c13)</span></li>
<li>stage/part/KPrViewModePreviewPageEffect.cpp <span style="color: grey">(a1bdf710bacd1ad669cab8518770e6494e8392b9)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.h <span style="color: grey">(f1a234b3a54326715a13954e89826bd361df528c)</span></li>
<li>stage/part/KPrViewModePreviewShapeAnimations.cpp <span style="color: grey">(c189a6d30252d5a8a152a3d08dd251b91d9bc83d)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.h <span style="color: grey">(73014f896b35ee6096026263b4fc5c48670aff22)</span></li>
<li>stage/part/KPrViewModeSlidesSorter.cpp <span style="color: grey">(0d101cfeed010d1d41762c2a49521ee6a405e00f)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(963dfad2c714f24ad34ae7cd09e8b2e3d457f7ae)</span></li>
<li>libs/flake/KoToolProxy.h <span style="color: grey">(6723c9c7c6e5404448d969606d267c72c5b0b3e6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>