<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119168/">https://git.reviewboard.kde.org/r/119168/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMHO definitions should be only set for those source files for which they are interesting.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Reason is that any definition becomes a dep for the .o file compiled, and if the dep changes, the source file has to be recompiled because the definition could influence te created .o file. So such global definitions are a pain for those of us who check different build configurations, because any change means a complete rebuild of everything.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently I would rather like to see headers generated and explicitely included by those files which make use of the switch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So not in favour of this change, rather would like the opposite to happen, removal of the definition addition in the central CMakeLists.txt.</p></pre>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On August 12th, 2014, 10:03 nachm. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2014, 10:03 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cleanup: COMPILING_TESTS is inherited in subdirs so it needs to be set only once</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested by building with tests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/CMakeLists.txt <span style="color: grey">(a9b2b65b4bd35ed1258c2cc3ffb51afe626c13a7)</span></li>
<li>words/part/tests/CMakeLists.txt <span style="color: grey">(1d66fb21c392b6e22165f0e91a2ce600aae60f60)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(839b861c0a93b5cc2244b2565cda87f144e1429c)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(e3ae4dd7849fd49f99f06bc7cd1dcf90adb5fc61)</span></li>
<li>libs/koreport/CMakeLists.txt <span style="color: grey">(26d299c54189f5b402348baa1821f7641a1afd74)</span></li>
<li>plan/CMakeLists.txt <span style="color: grey">(d9e24d868daf3fbbfe7c2253d34aef4ed50356ae)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(f79eea988d2066d90ebab0dab70f339b4ce6185d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119168/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>