<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118643/">https://git.reviewboard.kde.org/r/118643/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 10th, 2014, 4:07 p.m. UTC, <b>Camilla Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As long as it builds and and is marked as experimental (in the gui strings) I am fine with it getting merged. This is not a review though. I'll let someone else do that if they want to.</p></pre>
</blockquote>
<p>On August 10th, 2014, 4:32 p.m. UTC, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not really experimental. It's just not complete. The things that are in there work well.</p></pre>
</blockquote>
<p>On August 10th, 2014, 4:47 p.m. UTC, <b>Camilla Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">well incomplete then - just so we warn the user that we know there is still work to do</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am fine with it getting merged. :)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
As i am a little busy it will getting late ti implement table :/</p></pre>
<br />
<p>- mojtaba</p>
<br />
<p>On August 10th, 2014, 4:02 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann, Lassi Nieminen, mojtaba shahi, and Thorsten Zachmann.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2014, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch contains an export filter for wiki pages from odt files. It's done by request of the KDE documentation people, mainly mamarok.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that not all of the wiki spec is supported yet. Most notably, tables are not supported yet but that is the main priority for the next feature inclusion. Also links needs more work. But there is support for lists, headers, some general formatting and of course text in general.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(Originally moji was going to put up this review but he got a pain in his hands so I offered to do it instead. I may have missed some important comment but I'm sure he will add to the comments then.)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lots of manual testing during development</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libodf2/CMakeLists.txt <span style="color: grey">(8829a3c)</span></li>
<li>filters/libodf2/KoOdfListLevelProperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoOdfListLevelProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoOdfListStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoOdfListStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoOdfStyleManager.h <span style="color: grey">(9bc51f4)</span></li>
<li>filters/libodf2/KoOdfStyleManager.cpp <span style="color: grey">(7e558c7)</span></li>
<li>filters/libodf2/KoOdfStyleProperties.cpp <span style="color: grey">(f9d6d10)</span></li>
<li>filters/libodfreader/OdfTextReader.h <span style="color: grey">(f5636e4)</span></li>
<li>filters/libodfreader/OdfTextReader.cpp <span style="color: grey">(31dfba5)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.h <span style="color: grey">(4c82a02)</span></li>
<li>filters/libodfreader/OdfTextReaderBackend.cpp <span style="color: grey">(b6beb7d)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(805ca28)</span></li>
<li>filters/words/wiki/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/OdfReaderWikiContext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/OdfReaderWikiContext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/OdtReaderWikiBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/OdtReaderWikiBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/WikiExport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/WikiExport.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/export/words_wiki_export.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wiki/wiki-format.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118643/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>