<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119609/">https://git.reviewboard.kde.org/r/119609/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 8th, 2014, 11:27 a.m. UTC, <b>Dmitry Kazakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119609/diff/2/?file=302163#file302163line187" style="color: black; font-weight: bold; text-decoration: underline;">krita/ui/kis_doc2.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KisLayerSP</span> <span class="n">m_layer</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This variable looks suspicious. Do you really need to store any layer here?</p></pre>
</blockquote>
<p>On August 8th, 2014, 12:10 p.m. UTC, <b>Somsubhra Bairi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This can be avoided if we can get hold of the the root layer of the document's image instance. I tried KisImage::rootLayer() and KisImage::root() but it didn't work in my case.</p></pre>
</blockquote>
<p>On August 8th, 2014, 12:49 p.m. UTC, <b>Dmitry Kazakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you mean by "get hold"? The root layer is always stored in both KisImage::root() and KisImage::rootLayer(). They both return the same object by via a different pointer type. What is the problem with it?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had some problem with type-casting KisNode and KisLayer. But that's fixed now and this extra variable in KisDoc2 is not needed now. I'll update this patch soon.</p></pre>
<br />
<p>- Somsubhra</p>
<br />
<p>On August 8th, 2014, 11:02 a.m. UTC, Somsubhra Bairi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Somsubhra Bairi.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2014, 11:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Animation support in Krita.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
This is a full diff of the 'animator-plugin-somsubhra' branch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Few things in the layer box of the timeline do not work and cause random crash.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/widgets/kis_animation_selector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/widgets/kis_animation_selector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/KoDocument.cpp <span style="color: grey">(e452edb)</span></li>
<li>krita/ui/kis_onion_skin_loader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_onion_skin_loader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranim/kis_kranim_loader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranim/kis_kranim_loader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranim/kis_kranim_saver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranim/kis_kranim_saver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranim/kis_kranim_tags.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranimstore/kis_animation_store.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranimstore/kis_animation_store.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kranimstore/kis_animation_store_writer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/kranim_sequence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/kranim_sequence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/kranimseq_export.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/sequence_generator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/sequence_generator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/CMakeLists.txt <span style="color: grey">(02a9509)</span></li>
<li>krita/ui/forms/wdganimationselector.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_doc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_doc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_factory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_factory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_part.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_part.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_player.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animation_player.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_animator_aboutdata.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/kis_config.h <span style="color: grey">(18a80f4)</span></li>
<li>krita/ui/kis_config.cc <span style="color: grey">(815fe56)</span></li>
<li>krita/ui/kis_doc2.h <span style="color: grey">(5f9a62f)</span></li>
<li>krita/ui/kis_doc2.cc <span style="color: grey">(a33a0e5)</span></li>
<li>krita/plugins/extensions/dockers/animator/onionskin_dock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/onionskin_dock.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/CMakeLists.txt <span style="color: grey">(defea52)</span></li>
<li>krita/plugins/formats/kranimseq/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/kranimseq/kis_wdg_options_kranimseq.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_settings_dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_settings_dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_frame.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_frame.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_layer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_layer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_layerbox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_animation_layerbox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_frame_box.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_frame_box.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_layer_contents.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_layer_contents.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_opacity_selector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_opacity_selector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_opacity_selector_view.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_opacity_selector_view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_timeline.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_timeline.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_timeline_header.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/kis_timeline_header.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/krita_animator.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_playback_dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>extras/thumbnail/CMakeLists.txt <span style="color: grey">(d0dd623)</span></li>
<li>extras/thumbnail/kritaanimation_kranim_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/CMakeLists.txt <span style="color: grey">(3668a56)</span></li>
<li>krita/animator/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/krita_animationdock.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimation.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimation.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimation.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimation_part_init.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimationpart.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/kritaanimationrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/animator/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/data/input/CMakeLists.txt <span style="color: grey">(90c72d1)</span></li>
<li>krita/plugins/extensions/CMakeLists.txt <span style="color: grey">(182240c)</span></li>
<li>krita/plugins/extensions/dockers/CMakeLists.txt <span style="color: grey">(b14831f)</span></li>
<li>krita/plugins/extensions/dockers/animator/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_dock.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_dock.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/extensions/dockers/animator/animator_playback_dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119609/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>